Skip to content

Fix multiple config issue #2518 #2520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 20, 2017
Merged

Fix multiple config issue #2518 #2520

merged 4 commits into from
Apr 20, 2017

Conversation

@NoahDragon
Copy link
Member

@NoahDragon NoahDragon commented Apr 18, 2017 •
edited
Loading

Thank you for creating a pull request to contribute to Hexo code! Before you open the request please review the following guidelines and tips to help it be more easily integrated:

  • Add test cases for the changes.
  • Passed the CI test.

@NoahDragon NoahDragon changed the title Update index.js Fix multiple config issue #2518 Apr 18, 2017
@coveralls
Copy link

coveralls commented Apr 18, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.0007%) to 97.183% when pulling eff35b6 on Fix-multi-config-issue-#2518 into 5134cba on master.

@coveralls
Copy link

coveralls commented Apr 18, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.0007%) to 97.183% when pulling 6e30d01 on Fix-multi-config-issue-#2518 into 5134cba on master.

This was referenced Apr 18, 2017
Closed
Closed
@coveralls
Copy link

coveralls commented Apr 19, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.0007%) to 97.183% when pulling 931afed on Fix-multi-config-issue-#2518 into 5134cba on master.

@NoahDragon
Copy link
Member Author

NoahDragon commented Apr 19, 2017

Added test cases from #2521

@coveralls
Copy link

coveralls commented Apr 19, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.0007%) to 97.183% when pulling 3552c92 on Fix-multi-config-issue-#2518 into 5134cba on master.

This was referenced Apr 19, 2017
Closed
Closed
teggr
teggr approved these changes Apr 20, 2017
View reviewed changes
Copy link

@teggr teggr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested locally and these changes fix #2518

@NoahDragon NoahDragon merged commit fbdee90 into master Apr 20, 2017
This was referenced Apr 21, 2017
Closed
Closed
@NoahDragon NoahDragon deleted the Fix-multi-config-issue-#2518 branch May 23, 2017 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@teggr teggr teggr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NoahDragon @coveralls @teggr