Add tests for og:updated_time in open_graph helper, and add ability to turn it off #1973
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I might be one of very few people who have ever tried to do this…
I deploy my static site from CircleCI to S3 automatically (the tool I used to actually push the files to S3 compares the MD5 hashes of the locally generated files against those in AWS and skips any that haven't change) when I push to
masterbecause on each build theog:updated_timechanges it re-uploads each article.I've worked around this by now after discovering if you set the
updatedoption of theopen_graphhelper to be a string that removes theog:updated_timemeta tag…… But this feels like a bit of a hack.It would be nice if you could just do:-
So that's what this pull requests adds support for. Also I notice the
og:updated_timefeature didn't have any tests, so I added a couple.Thanks.
Matt