Support root path configure for img tag #1444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This pull request only fix the image tag. |
liuhongjiang
force-pushed
the
prepend-root-to-img-tag
branch
from
5753e49 to
570b46b
Compare
Contributor
Author
|
I test run the test with iojs using the master branch, it gets the same error, I think this may be related to the recent upgrade of iojs. |
liuhongjiang
force-pushed
the
prepend-root-to-img-tag
branch
from
570b46b to
4ad77fe
Compare
Contributor
Author
|
Add one more commit to fix the problem, when the root path is set to a subdirectory, there is no this root path in the permalink of post. |
liuhongjiang
force-pushed
the
prepend-root-to-img-tag
branch
from
69a0e2e to
30d1953
Compare
liuhongjiang
force-pushed
the
prepend-root-to-img-tag
branch
from
30d1953 to
a11d7db
Compare
Current img tag doesn't prepend root path if it's not a slash. With this fix, the root path will be prepend to the img src if it's not a slash. This fix only works for the hexo tags, does not work for the markdown syntax of links and images. The issues of markdown links and images should be fixed in the hexo-renderer-marked module. Resolves: hexojs#1440
liuhongjiang
force-pushed
the
prepend-root-to-img-tag
branch
3 times, most recently
from
d6dd70c to
b801915
Compare
This commit fixs this problem, when the root path is set to a subdirectory, there is no this root path in the permalink of post.
liuhongjiang
force-pushed
the
prepend-root-to-img-tag
branch
from
b801915 to
657f9e7
Compare
Contributor
Author
|
I rebased the code on the latest master, And it has the same logic as this pull request: hexojs/hexo-renderer-marked#7 @Xuanwo please check it. |
Contributor
|
👍 |
Xuanwo
pushed a commit
that referenced
this pull request
Dec 21, 2015
Support root path configure for img tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current img tag doesn't prepend root path if it's not a slash. With
this fix, the root path will be prepend to the img src if it's not a
slash.
This fix only works for the hexo tags, does not work for the markdown
syntax of links and images. The issues of markdown links and images should
be fixed in the hexo-renderer-marked module.
Resolves: #1440