Skip to content

Conversation

SukkaW
Copy link
Member

@SukkaW SukkaW commented Dec 25, 2019

During writing proposal at hexojs/hexo#4010, I noticed strip-indent is used at hexo-renderer-marked and backtick_code filter.

Although strip-indent at hexo-renderer-marked will be removed in hexojs/hexo-renderer-marked#134, but after searching strip-indent at hexojs/hexo I found strip-indent mostly used for highlight in hexojs/hexo as well. It means we should add strip-indent inside highlightUtils.

After this PR is merged, strip-indent inside hexojs/hexo could be removed.

@SukkaW SukkaW requested a review from curbengh December 25, 2019 16:24
@coveralls
Copy link

coveralls commented Dec 25, 2019

Coverage Status

Coverage increased (+0.005%) to 96.78% when pulling e077fa6 on SukkaW:add-strip-indent into c876271 on hexojs:master.

@SukkaW SukkaW requested a review from a team December 27, 2019 01:00
@SukkaW SukkaW merged commit bca664d into hexojs:master Jan 1, 2020
SukkaW added a commit to SukkaW/hexo that referenced this pull request Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants