Skip to content

refactor: using typescript #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 20, 2022
Merged

refactor: using typescript #66

merged 6 commits into from
Feb 20, 2022

Conversation

himself65
Copy link
Member

No description provided.

Jack-Works
Jack-Works reviewed Apr 27, 2020
View reviewed changes
@himself65 himself65 changed the title refactor: using typescript [WIP]refactor: using typescript Apr 27, 2020
@himself65 himself65 changed the title [WIP]refactor: using typescript refactor: using typescript Apr 28, 2020
@himself65 himself65 marked this pull request as ready for review April 28, 2020 04:00
@himself65 himself65 force-pushed the refactor branch 2 times, most recently from db2d5eb to 7bc1cc6 Compare April 28, 2020 04:10
@coveralls
Copy link

coveralls commented Apr 28, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 96.679% when pulling d323446 on Himself65:refactor into a0599b5 on hexojs:master.

@yoshinorin
Copy link
Member

@himself65
Thank you for your contribution :)
Would you please wait for a while?

@segayuu @hexojs/core

@segayuu submitted PR for replace typescript to warehouse. It's tsconfig.json is the different between this PR's tsconfig.json.

So, should we create & release eslint-config-hexo-typescript (like eslint-config-hexo) first?

@himself65
Copy link
Member Author

Would you please wait for a while?
Sure, I'm on call whenever

@yoshinorin
Copy link
Member

@himself65
Sorry so slow reply.

We are released eslint-config-hexo 5.0.0. It is included typescript support and we have already merged it to this repository. Would you please rebase this PR and use esling-config hexo 5.0.0?

Thank you :)

@himself65
Copy link
Member Author

@himself65 Sorry so slow reply.

We are released eslint-config-hexo 5.0.0. It is included typescript support and we have already merged it to this repository. Would you please rebase this PR and use esling-config hexo 5.0.0?

Thank you :)

Ok, i try

@himself65 himself65 requested a review from yoshinorin February 11, 2022 15:41
SukkaW
SukkaW reviewed Feb 12, 2022
View reviewed changes
yoshinorin
yoshinorin reviewed Feb 12, 2022
View reviewed changes
@yoshinorin
Copy link
Member

[Question]:
Honestly, I'm not familiar with publishing a TS package to npm.
I have a TS package and it is build with tsc command before publish.

But this PR does not include build (tsc) command. So, how to publish to npm if we after merge this PR?

@himself65
Copy link
Member Author

[Question]: Honestly, I'm not familiar with publishing a TS package to npm. I have a TS package and it is build with tsc command before publish.

But this PR does not include build (tsc) command. So, how to publish to npm if we after merge this PR?

I will add build command

yoshinorin
yoshinorin approved these changes Feb 20, 2022
View reviewed changes
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm going to publish a new version :)

@yoshinorin yoshinorin merged commit 5a93947 into hexojs:master Feb 20, 2022
@yoshinorin yoshinorin mentioned this pull request Mar 6, 2022
Merged
@himself65 himself65 deleted the refactor branch March 6, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshinorin yoshinorin yoshinorin approved these changes

@SukkaW SukkaW Awaiting requested review from SukkaW

+1 more reviewer

@Jack-Works Jack-Works Jack-Works left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@himself65 @coveralls @yoshinorin @Jack-Works @SukkaW