Test failures

[curbengh]

@hexojs/core
Anyone has working unit tests in their local machine?

I ran test on master branch and 30/460 tests failed. No issue on travis though.

I ran into this issue when I briefly attempted to remove unneeded features (as per discussion). Once I execute test, there were so many errors, I didn't know where to start. I started rewind back the changes, to no avail. Turns out, it fails even in clean master branch.

[tomap]

I also tried myself on windows, and could not make it work I'll try with a mac later this week

…

On Wed, Sep 11, 2019 at 8:29 AM curbengh ***@***.***> wrote: @hexojs/core <https://github.com/orgs/hexojs/teams/core> Anyone has working unit tests in their local machine? I ran test on master branch and 30/460 tests failed. No issue on travis though. I ran into this issue when I briefly attempted to remove unneeded features (as per discussion). Once I execute test, there were so many errors, I didn't know where to start. I started rewind back the changes, to no avail. Turns out, it fails even in clean master branch. — You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub <#13?email_source=notifications&email_token=AABFR7U7L53AYT6BJMKNLCDQJCF3PA5CNFSM4IVP2FZKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HKT7NZA>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABFR7WHE3NWPUIACSWEXLDQJCF3PANCNFSM4IVP2FZA> .

[SukkaW]

That's odd, the test on my device successed.

$ npm test

> hexo-bunyan@2.0.0 test /mnt/d/Project/Sukka/hexo-bunyan
> make test

test -z "" || test -n "" || \
        (node -e 'require("dtrace-provider").createDTraceProvider("isthisthingon")' && \
        echo "\nNote: Use 'SKIP_DTRACE=1 make test' to skip parts of the test suite that require root." && \
        sudo ./node_modules/.bin/nodeunit test/dtrace.test.js)
./node_modules/.bin/nodeunit test/add-stream.test.js test/buffer.test.js test/child-behaviour.test.js test/cli.test.js test/ctor.test.js test/cycles.test.js test/error-event.test.js test/level.test.js test/log.test.js test/other-api.test.js test/process-exit.test.js test/raw-stream.test.js test/ringbuffer.test.js test/safe-json-stringify.test.js test/serializers.test.js test/src.test.js test/stream-levels.test.js

add-stream.test.js
✔ non-writables passed as stream
✔ proper stream

buffer.test.js
(node:1268) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
✔ log.info(BUFFER)

child-behaviour.test.js
✔ child can add stream
✔ child can set level of inherited streams
✔ child can set level of inherited streams and add streams
✔ child should not lose parent "hostname"

cli.test.js
✔ --help
✔ -h
✔ --bogus
✔ simple.log
✔ cat simple.log
✔ time: simple.log local long
✔ time: simple.log utc long
✔ time: simple.log local short
✔ time: simple.log utc short
✔ simple.log with color
✔ extrafield.log
✔ extrafield.log with color
✔ bogus.log
✔ bogus.log -j
✔ all.log
✔ simple.log doesnotexist1.log doesnotexist2.log
✔ multiple logs
✔ multiple logs, bunyan format
✔ log1.log.gz
✔ mixed text and gzip logs
✔ --level 40
✔ --condition "this.level === 10 && this.pid === 123"
✔ --condition "this.level === TRACE
✔ multiple --conditions
✔ robust req handling
✔ should not crash on corpus/old-crashers/*.log
✔ client_req extra newlines, client_res={} (pull #252)
✔ should only show nonempty response bodies

ctor.test.js
✔ ensure Logger creation options
✔ ensure Logger constructor is safe without new
✔ ensure Logger creation options (createLogger)
✔ ensure Logger child() options
✔ ensure Logger() rejects non-Logger parents

cycles.test.js
✔ cycles

error-event.test.js
✔ error event on file stream (reemitErrorEvents=undefined)
✔ error event on file stream (reemitErrorEvents=true)
✔ error event on file stream (reemitErrorEvents=false)
✔ error event on raw stream (reemitErrorEvents=undefined)
✔ error event on raw stream (reemitErrorEvents=false)
✔ error event on raw stream (reemitErrorEvents=true)

level.test.js
✔ log.level() -> level num
✔ log.level(<const>)
✔ log.level(<num>)
✔ log.level(<name>)
✔ log.level(FATAL + 1)
✔ log.level(<weird numbers>)
✔ log.level(<invalid values>)

log.test.js
✔ log.LEVEL() -> boolean
✔ log.info(undefined, <msg>)
✔ log.info(<fields>, undefined)
✔ log.info(null, <msg>)
✔ log.info(<fields>, null)
✔ log.info(<str>)
✔ log.info(<fields>, <str>)
✔ log.info(<bool>)
✔ log.info(<fields>, <bool>)
✔ log.info(<num>)
✔ log.info(<fields>, <num>)
✔ log.info(<function>)
✔ log.info(<fields>, <function>)
✔ log.info(<array>)
✔ log.info(<fields>, <array>)
✔ log.info(null)

other-api.test.js
✔ bunyan.<LEVEL>s
✔ bunyan.resolveLevel()

process-exit.test.js
✔ log with rotating file stream will terminate

raw-stream.test.js
✔ raw stream
✔ raw streams and regular streams can mix
✔ child adding a non-raw stream works

ringbuffer.test.js
✔ ringbuffer

safe-json-stringify.test.js
✔ __defineGetter__ boom
✔ __defineGetter__ boom, without safe-json-stringify
✔ defineProperty boom
✔ defineProperty boom, without safe-json-stringify

serializers.test.js
✔ req serializer
✔ res serializer
✔ err serializer
✔ err serializer: custom serializer
✔ err serializer: long stack
✔ do not apply serializers if no record key

src.test.js
✔ src

stream-levels.test.js
✔ default stream log level
✔ default stream, level=DEBUG specified
✔ default stream, level="trace" specified
✔ stream & level="trace" specified
✔ one stream, default level
✔ one stream, top-"level" specified
✔ one stream, stream-"level" specified
✔ one stream, both-"level" specified
✔ two streams, both-"level" specified
✔ two streams, one with "level" specified
✔ log level 0 to turn on all logging

OK: 460 assertions (9878ms)

Debian 10 (WSL1) on Windows 10.

[curbengh]

Can I have your "node_modules" folder? you might wanna replace all occurrence of "/home/SukkaW/hexo-stuff/hexo-util" string in all the package.json files, unless you don't mind the public to know your folder structure.

---

Since it passes for you, can you takeover the initial refactor (remove features)? rest of us can do the es6-fy and spacing.

I propose the following migration:

1. Create a new branch mini with 7518ecf...349fd13
2. Remove features and corresponding tests.
3. pass travis.
4. es6-fy and spacing.
5. pass eslint-config-hexo@3.
6. Copy lib/bunyan.js and the relevant tests to hexo-log
7. Pass travis in hexo-log
8. Archive this repo

I prefer putting it into hexo-log, than creating a new repo hexo-bunyan2. With reduced features, no benefit publishing it to npm.