chore(toast): making toast compatible with latest RA #5034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e85174f The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Caution Review failedThe pull request is closed. WalkthroughThis pull request updates the toast component by changing the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ToastComponent
participant useToastHook
participant ToastRegion
User->>ToastComponent: Clicks close button
ToastComponent->>useToastHook: Triggers onTransitionEnd
useToastHook-->>ToastComponent: Sets data-toast-exiting=true
ToastComponent->>ToastRegion: Notifies exit state update
ToastRegion-->>ToastComponent: Removes toast post-animation
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
@heroui/accordion
@heroui/autocomplete
@heroui/alert
@heroui/avatar
@heroui/badge
@heroui/breadcrumbs
@heroui/button
@heroui/calendar
@heroui/card
@heroui/checkbox
@heroui/chip
@heroui/code
@heroui/date-input
@heroui/date-picker
@heroui/divider
@heroui/drawer
@heroui/dropdown
@heroui/form
@heroui/image
@heroui/input-otp
@heroui/input
@heroui/kbd
@heroui/link
@heroui/listbox
@heroui/menu
@heroui/modal
@heroui/navbar
@heroui/number-input
@heroui/pagination
@heroui/popover
@heroui/progress
@heroui/radio
@heroui/ripple
@heroui/scroll-shadow
@heroui/select
@heroui/skeleton
@heroui/slider
@heroui/snippet
@heroui/spacer
@heroui/spinner
@heroui/switch
@heroui/table
@heroui/tabs
@heroui/toast
@heroui/tooltip
@heroui/user
@heroui/react
@heroui/system
@heroui/system-rsc
@heroui/theme
@heroui/use-aria-accordion
@heroui/use-aria-accordion-item
@heroui/use-aria-button
@heroui/use-aria-link
@heroui/use-aria-modal-overlay
@heroui/use-aria-multiselect
@heroui/use-callback-ref
@heroui/use-clipboard
@heroui/use-data-scroll-overflow
@heroui/use-disclosure
@heroui/use-draggable
@heroui/use-image
@heroui/use-infinite-scroll
@heroui/use-intersection-observer
@heroui/use-is-mobile
@heroui/use-is-mounted
@heroui/use-measure
@heroui/use-pagination
@heroui/use-real-shape
@heroui/use-ref-state
@heroui/use-resize
@heroui/use-safe-layout-effect
@heroui/use-scroll-position
@heroui/use-ssr
@heroui/use-theme
@heroui/use-update-effect
@heroui/aria-utils
@heroui/dom-animation
@heroui/framer-utils
@heroui/react-rsc-utils
@heroui/react-utils
@heroui/shared-icons
@heroui/shared-utils
@heroui/stories-utils
@heroui/test-utils
commit: |
macci001
force-pushed
the
macci001/eng-2270
branch
from
7055790 to
6bd249c
Compare
macci001
force-pushed
the
macci001/eng-2270
branch
from
6bd249c to
c05c67a
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.changeset/purple-seahorses-sin.md (1)
6-7: Fix minor grammatical issuesThere are a couple of small improvements to make in the changeset description:
- Add "the" before "toast" on line 6
- Add a space between "ReactNode" and the issue reference on line 7
-Making toast compatible with RA upgrade. -Changing the type of description prop to ReactNode(#5033). +Making the toast compatible with RA upgrade. +Changing the type of description prop to ReactNode (#5033).🧰 Tools
🪛 LanguageTool
[uncategorized] ~6-~6: You might be missing the article “the” here.
Context: ...patch --- Making toast compatible with RA upgrade. Changing the type of descripti...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
[uncategorized] ~7-~7: Possible missing comma found.
Context: ...e with RA upgrade. Changing the type of description prop to ReactNode(#5033).(AI_HYDRA_LEO_MISSING_COMMA)
packages/components/toast/src/use-toast.ts (1)
494-508: Improved close button behavior with exit animations.The
getCloseButtonPropsfunction now setsisToastExitingstate to true when the close button is pressed, which allows the exit animation to complete before the toast is actually removed from the DOM.However, there seems to be an unnecessary dependency on
stateandtoastin the dependency array as these values aren't directly used in the function. Consider removing them.- [setIsToastExiting, onClose, state, toast], + [setIsToastExiting, onClose],
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (9)
.changeset/purple-seahorses-sin.md(1 hunks)apps/docs/content/components/toast/custom-styles.raw.jsx(1 hunks)apps/docs/content/docs/components/toast.mdx(1 hunks)packages/components/toast/__tests__/toast.test.tsx(1 hunks)packages/components/toast/package.json(1 hunks)packages/components/toast/src/toast-region.tsx(1 hunks)packages/components/toast/src/use-toast.ts(7 hunks)packages/components/toast/stories/toast.stories.tsx(2 hunks)packages/core/theme/src/components/toast.ts(2 hunks)
🧰 Additional context used
🪛 LanguageTool
.changeset/purple-seahorses-sin.md
[uncategorized] ~6-~6: You might be missing the article “the” here.
Context: ...patch --- Making toast compatible with RA upgrade. Changing the type of descripti...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
[uncategorized] ~7-~7: Possible missing comma found.
Context: ...e with RA upgrade. Changing the type of description prop to ReactNode(#5033).
(AI_HYDRA_LEO_MISSING_COMMA)
🔇 Additional comments (17)
packages/components/toast/src/toast-region.tsx (1)
84-84: Reverse order rendering for toast notificationsThe change to reverse the order of toast notifications is now implemented correctly. This ensures proper stacking order when new toasts are added, which is a common pattern for notification systems.
packages/components/toast/__tests__/toast.test.tsx (1)
120-122: Improved toast exit state verificationThe test has been updated to check for the new
data-toast-exitingattribute instead of counting DOM elements. This is a more robust approach as it directly tests the component's state rather than relying on side effects.packages/components/toast/package.json (1)
49-52: Upgraded React Aria dependencies to stable versionsThe React Aria dependencies have been upgraded from beta to stable versions, which is a good practice for production code. This addresses the main objective of making the toast component compatible with the latest RA.
apps/docs/content/components/toast/custom-styles.raw.jsx (2)
14-14: Simplified styling approach using border properties.The class structure has been streamlined from multiple separate classes to a consolidated class string, improving readability.
16-16: Updated color styling to use border properties.The approach to visual differentiation has shifted from using pseudo-elements with
before:bg-*to using border properties withborder-l-*. This provides a cleaner and more direct styling method.packages/core/theme/src/components/toast.ts (2)
47-65: Enhanced customization with pseudo-element extensions.These new classes add support for customizable extensions at the top and bottom of the toast component through pseudo-elements. This provides a more flexible styling approach by allowing for additional interactive areas around the toast.
157-166: Improved exit animation state tracking.The animation classes have been updated from using
data-[animation=exiting]todata-[toast-exiting=true], which provides a more explicit and semantically clear way to track the toast's exit state. This change improves the overall clarity of the animation logic.packages/components/toast/stories/toast.stories.tsx (2)
294-298: Updated color mapping to use border-based styling.The color mapping has been updated to use
border-l-*classes instead ofbefore:bg-*classes, aligning with the new border-based styling approach across the component. This change brings consistency to the component styling system.
313-313: Simplified class structure for toast container.The toast container classes have been consolidated for better maintainability and clarity, matching the changes made in other files. This ensures styling consistency throughout the codebase.
apps/docs/content/docs/components/toast.mdx (1)
279-284: Reintroduced severity attribute for Toast component.The
severityattribute has been appropriately reintroduced in the Toast Props section, clarifying that it applies to individual toast instances rather than the provider. This ensures developers understand the correct scope and usage of this attribute.packages/components/toast/src/use-toast.ts (7)
35-35: Enhanced flexibility for toast descriptions.Changing
descriptionfromstringtoReactNodeallows for more versatile content in toast descriptions, including formatted text, links, or even interactive components.
268-272: LGTM - Simplified prop destructuring from useToastAria.The removal of
closeButtonPropsfrom the destructuring suggests that the close button handling has been refactored elsewhere in the component.
281-281: Added exit state tracking.The new
isToastExitingstate variable improves the toast lifecycle management by tracking when a toast is in the process of being removed, which enables proper exit animations.
285-285: Optimized layout updates during toast exit.Adding the
isToastExitingcondition prevents unnecessary layout calculations when a toast is being removed, which improves performance.
308-308: Updated effect dependencies for exit state.Including
isToastExitingin the dependency array ensures the layout effect responds to changes in the toast's exit state, which is important for proper cleanup and animation sequencing.
391-443: Enhanced toast positioning and exit animation handling.The refactored
getToastPropsfunction now:
- Calculates extension values based on adjacent toast heights
- Sets CSS custom properties for styling
- Adds a data attribute for exit state
- Handles transition end to properly remove the toast from the heights array
This is a significant improvement that allows for better animations and smoother toast transitions.
624-624: Updated motion props dependencies for exit state.Adding
isToastExitingto the dependency array ensures that motion properties are recalculated when the toast's exit state changes, which is essential for proper animation handling.
wingkwong
approved these changes
Mar 22, 2025
jrgarciadev
approved these changes
Mar 27, 2025
jrgarciadev
added a commit
that referenced
this pull request
Apr 6, 2025
* chore: org name change (#4596) * chore: update brand name (#4600) * fix(calendar): function components cannot be given refs (#4614) * docs(modal): fix small typos and add clarifying language (#4629) * chore(deps): bump RA versions (#4611) * chore(deps): bump RA versions * chore(deps): bump @internationalized/date * chore(docs): update RA versions * chore(docs): update versions * chore(docs): use string type * chore(deps): update @react-types versions * refactor(docs): undo version change since they will be removed in another PR * feat: tailwind variants upgrade (#4386) * feat: tailwind variants upgrade * chore: restore npmrc * chore: adjust pkgs * fix: versions * fix: lock file * chore(changeset): update package name * chore(deps): use fixed version * fix(test): incorrect package name --------- Co-authored-by: աӄա <[email protected]> * feat: add fn win alt keys (#4638) * feat: add new keys * feat: add new keys * chore: update docs & storybook as well --------- Co-authored-by: WK Wong <[email protected]> * fix(use-image): load images after props change (#4523) * fix(use-image): load image after props change * chore(changeset): add changeset * refactor(use-image): remove unused props * feat(use-image): add test case * fix(use-image): apply useCallback to load & remove status check * chore(changeset): update package name * feat: global labelPlacement prop (#4346) * feat: adding the support for labelPlacement globally * chore: reafctoring * chore: updating the dependency * chore(changeset): update package name * chore: adding Marcus's suggestions --------- Co-authored-by: աӄա <[email protected]> * fix(form): use native as default validation behavior (#4425) * fix(form): use native as default validation behavior * docs(form): delete explicit validationBehavior=native * test(form): adjusted form test validation behaviors * chore(form): adjusted stories with forms * chore(changeset): changed form default validation behavior to native * chore(changeset): removed packages with only test changes * chore(changeset): change to patch * chore(changeset): update package name * refactor(docs): update package name * refactor(docs): update to heroui --------- Co-authored-by: աӄա <[email protected]> * feat(spinner): new spinner variants (#4555) * refactor(spinner): add default variant * feature(spinner): add gradient variant * feature(spinner): add dots variant * feature(spinner): add dots-blink variant * feature(spinner): add spinner-bars * chore(spinner): add variants storybook * chore: adding variants to docs * chore: simplyfying the styles and modifying docs * chore: nits * chore: updating the dots and dots-blink animation * chore: nits * chore: adding Marcus' suggestions * chore: adding Marcus's suggestions * chore: adding junior's suggestions --------- Co-authored-by: Maharshi Alpesh <[email protected]> * fix: rename wrapper to tab wrapper (#4636) * fix: rename wrapper to tab wrapper * docs: update * docs: update * docs: update * fix: rename wrapper to tab wrapper * refactor: remove feature request from issue template (#4661) * refactor(.github): remove feature request template * refactor(.github): add a link to redirect to discussion (feature request category) * docs(table): include TS examples to show Selection type usage (#4793) * fix(listbox): unexpected scrollShadow on virtualized listbox (#4784) * fix(listbox): add scroll height & scroll top to listbox * fix(use-data-scroll-overflow): handle scrollHeight & scrollTop in virtualization * chore(changeset): add changeset * refactor(theme): replace left & right by start & end to support RTL (#4782) * fix(date-picker): deprecate dateInputClassNames (#4780) * chore(date-picker): add missing slots comments * fix(date-picker): remove dateInputClassNames * fix(date-picker): use classNames instead of dateInputClassNames * chore(docs): add missing attributes * fix(date-picker): use classNames instead of dateInputClassNames * feat(changeset): add changeset * fix(docs): broken type * refactor(navbar): remove dropdown menu width (#4757) * refactor: remove dropdown menu width * refactor: shorter description * refactor: rename instances of NextUI to Hero UI (#4645) * docs: use the correct org for `img.shields.io` license in README * docs: update opencollective org name * docs: use correct org name in site footer * docs: update image urls for heroui pro sections * docs: update laravel installation keywords in route config * docs: add `heroui` tag to `Introducing HeroUI` blog post * fix: use correct names in `plop/components/src` templates * chore: add empty changeset * fix: revert image urls back to `nextuipro.nyc3.cdn.digitaloceanspaces...` * chore: undo footer change * chore: update incorrect brand name * chore(docs): nextui -> heroui --------- Co-authored-by: աӄա <[email protected]> * fix(input): missing clear button with file input type (#4599) * fix(theme): sync with input theme on labelPlacement (#4597) * fix(theme): sync with input theme on labelPlacement * chore(select): revise width for labelPlacement * chore(changeset): add changeset * test(input): input interaction tests (#4579) * test(input): user interaction tests * test(input): missing act wrappers --------- Co-authored-by: WK Wong <[email protected]> * fix(calendar): rtl navigation (#4565) * fix(calendar): rtl navigation * chore(changeset): fixed reverse behavior of NextButton and PrevButton in the RTL calendar * chore(changeset): update package name * refactor(calendar): prefer isRTL and use className in theme package instead * chore(changeset): add theme package as well * chore(calendar): add min theme package to 2.4.7 --------- Co-authored-by: աӄա <[email protected]> * refactor: remove unnecessary className passing to tv and make naming consistent (#4558) * refactor: remove unnecessary className passing to tv * refactor(button): move styles to getButtonProps * refactor: rename classNames to styles to keep the naming consistent * fix: deprecation warning triggered by internal onClick (#4557) * fix(use-aria-link): onClick deprecation warning * fix(use-aria-button): onClick deprecation warning * feat(changeset): add changeset * fix(use-aria-button): incorrect prop name * chore(changeset): update package name * ci: add pkg pr new (#4540) * ci: add pkg pr new * ci: add pkg pr new * chore(workflow): update repo name --------- Co-authored-by: աӄա <[email protected]> * chore(docs): remove shouldBlockScroll prop in Tooltip page (#4539) * fix(use-pagination): controlled page after delay (#4536) * fix(use-pagination): add page to dependency for scrollTo * feat(changeset): add changeset * chore(changeset): update package name * fix(tooltip): accessing element.ref was removed in React 19 issue (#4531) * fix(tooltip): accessing element.ref was removed in React 19 issue * chore(changeset): update package name * fix: correctly dismissable default value (#4524) * fix: correctly dismissable default value * fix: correctly dismissable default value * chore(changeset): update package name --------- Co-authored-by: աӄա <[email protected]> * fix(theme): input height in innerWrapper in Select (#4512) * fix(select): fix input height #4321 * chore(select): changed package name in changeset to theme * chore(select): updated changeset message * chore(changeset): update package name --------- Co-authored-by: աӄա <[email protected]> * fix: inert value in next15 (#4491) * feat: add post install * feat: add postinstall * feat: add postinstall * fix: type * fix: type * fix: next version * chore(changeset): update package name --------- Co-authored-by: աӄա <[email protected]> * refactor: remove cursor-hit in hiddenInputClasses (#4474) * refactor: remove cursor-hit in hiddenInputClasses * Create lazy-ants-exercise.md * chore(changeset): update package name --------- Co-authored-by: աӄա <[email protected]> * feat(table): virtualization (#4285) * feat: baseline virtualization for table * merge branch canary * fix: table layout * fix: calc header height w layouteffect to offset padding * Merge branch 'canary' into feat/eng-1633-virtualization-for-table * chore: remove unused files and comments * chore: add missing package * feat: add shouldVirtualize conditional to render virtualized-table * feat: update docs for table * feat: use wrapper to support theme styles * chore: add changeset * chore(changeset): update package name * chore(deps): pnpm-lock.yaml * fix(table): outdated package name * chore(changeset): add issue number * fix(deps): keep the version consistent with other components * fix(table): incorrect displayName * refactor(table): use VirtualizedTemplate * chore(deps): bump `@tanstack/react-virtua` * chore(deps): typecheck issue * fix(table): do not use any type * chore: remove auto virtualization --------- Co-authored-by: աӄա <[email protected]> Co-authored-by: Junior Garcia <[email protected]> * feat(toast): introduce Toast component (#4437) * feat: initial commit * chore: adding the animation * chore: nits * chore: fixes and adding draft1 of stories * chore: adding the docs draft * chore: adding the swiping interaction for toast removal * chore: adding the tests * fix: improving the progress bar logix * chore: refactoring and refining the animations * fix: making the animations compatible with the positons * chore: fixing the styles * chore: modifying the animations * chore: improving the animations * chore: adding the decorator to the story-book * chore: fixing the animations and positions * fix: handle expand region on touch * feat: adding the promises support * chore: updating the styles * chore: improving styles * chore: styles correction * fix: adding junior's suggestions * chore: correcting styles * fix: fixing the timer behavior * chore: adding the spinner to the toast * chore: full width for mobile * chore: modifying styles * chore: fixing the positions on smaller devices * chore: adding story with description * chore: adding credits for sonner * fix: adding junior's suggestions * chore: adding the exit animation * fix: adding junior's suggestions * chore: improving the swipe animations * fix: fixing the swipe animations on touch * chore: adding tests * chore: adding swipe threshild and initial position variable * fix: fixing autoclose in timeout * chore: modifying the docs * chore: fixing the conflict * chore: adding marcus' suggestions * chore: adding the bottom animations * chore: modying docs * chore: removing nextui references * chore: adding info about the provider * chore: updating the docs * chore: versions in package.json * chore: nits * chore: adding junior's suggestions * chore: nits * fix: applying junior's suggestions * chore: adding junior's suggestions * chore: using domMax * fix: adding Marcus's suggestions * chore: add global toast props and custom close icon * chore: adding the defaultTimout provider prop * chore: modifying defaultTimeout * chore: nits * fix: adding Marcus' suggestions * chore: fixing bg * chore(deps): bump RA deps * fix: fixing the color discrepancy due to the timer * chore: moving the kapan ai to the left side * refactor(toast): update author * chore: nit * chore: improvements * chore: updating the solid variant --------- Co-authored-by: Junior Garcia <[email protected]> Co-authored-by: WK Wong <[email protected]> * fix(docs): correct Tab usage example (#4821) * chore(docs): add note itemHeight for virtualization (#4822) * chore(docs): add note itemHeight for virtualization * fix: format * fix(docs): fix horizontal scrolling example in scroll-shadow (#4820) * refactor: update author in package.json (#4800) * feat(button): export PressEvent for onPress event typing (#4819) * fix(docs): failed to install dependencies in StackBlitz (#4639) * chore(Docs): remove step 2 from "Using use-theme-hook" (#4797) * fix(docs): incorrect code Modal placement (#4652) * docs: update DatePicker example to remove "time" label as time selection is not supported in this example (#4443) * feat(button): export PressEvent for onPress event typing * revert unnecessary changes * chore: format --------- Co-authored-by: աӄա <[email protected]> Co-authored-by: Praharsh Bhatt <[email protected]> * fix(listbox): pass missing press events to usePress (#4812) * fix(listbox): pass missing press events to usePress * feat(listbox): add test case for press event * chore(changeset): add changeset * fix(checkbox): inherit stroke in CheckboxIcon (#4811) * fix: `SelectItem`, `ListboxItem`, and `AutocompleteItem` not to accept `value` props (#4653) * fix(select): `SelectItem` does not accept value props * refactor: do not use the index as `key` * Update .changeset/light-hairs-draw.md * chore: remove unnecessary `value` props * chore: update changeset * refactor: remove unnecessary value prop --------- Co-authored-by: WK Wong <[email protected]> * fix: pkg package scope (#4823) * fix: pkg package scope * fix: pkg package scope * fix: pkg package scope * fix(theme): border radius in Table when isMultiSelectable (#4808) * fix(theme): border radius in Table when isMultiSelectable * chore(theme): added changeset (#4807) * chore: removing the kapa ai for toast doc page (#4833) * fix(accordion): add data-slot attributes to accordion (#4832) * fix(accordion): add data-slot attributes to accordion * chore --------- Co-authored-by: Hovannes Markarian <[email protected]> Co-authored-by: աӄա <[email protected]> * chore(docs): update versions (#4836) * docs(themes): adding theme generator (#4626) * chore: adding xylish's contributions + modifying styles * chore: nextui to heroui * chore: colors in theme generator * chore: radiuses, disable-opacity * chore: fixing the configuration box styles * chore: adding the showcase elemtents * chore: modifying styles * chore: adding the fonts * chore: adding the scaling * chore: removing the calendar * feat: adding the border-width * chore: modifying style for mobile * chore: modifying the styles * chore: removing the NextUI references + small bug fix * chore: adding coderabits reviews * fix: borderWidth not getting applied on breadcrumbs and input * chore: rebasing * chore: modifying the styles * chore: updating the styles for the smaller devices * chore: refactoring * chore: improvements * chore: making the fonts workable * chore: making the fonts workable * chore: modifying the swatch according to the theme * chore: adding the default selected template * chore: modifying mobile styles * chore: fixing the popover * chore: nit * fix: fixing the select styles * chore: modifying the mobile styles * chore: modifying the styles * fix: adding junior's suggestions * fix: fixing the breadcrumb * fix: adding junior's suggestions * feat: introduce NumberInput (#4475) * feat(number-field): init structure * feat(deps): add `@nextui-org/button` & `@react-types/button` * feat(theme): export number-field * feat(number-field): storybook init structure * feat(number-field): add NumberFieldHorizontalStepper * feat(number-field): add NumberFieldHorizontalStepper * feat(theme): init number field theme * feat(number-field): number-field draft * refactor(number-field): revise stepper icons * feat(shared-icons): add ChevronLeftIcon * feat(theme): stepperButton styles * feat(theme): number-field styles * fix(number-field): label layout * feat(number-field): vertical stepper wrapper * feat(number-field): use-number-field (wip) * feat(number-field): add data-direction * feat(theme): center the text if it is horizontal stepper * feat(number-field): add HorizontalStepper * feat(number-field): add HideStepper * chore(number-field): revise minValue & defaultValue * feat(docs): init number field structure * fix(theme): outside-left styles * refactor(theme): remove labelPlacement styles * refactor(number-field): remove labelContent logic * refactor(number-field): remove labelPlacement args * feat(number-field): helper text * feat(number-field): revise number field stories * feat(number-field): description * refactor(number-field): revise number field stories * feat(theme): numberFieldLabelClasses * fix(number-field): incorrect button props * fix(number-field): typing issue on stepper buttons * chore(number-field): add aria-label * refactor(number-field): merge props * fix(number-field): pass originalProps instead * chore(number-field): revise Required story args * feat(number-field): add WithStepValue & WithWheelDisabled & revise stories * chore(number-field): add label to Required * feat(docs): number-field doc page * fix(number-field): typing issue * fix(number-field): test cases * fix(number-field): user.keyboard & defaultValue * fix(number-field): should work with defaultValues * chore(number-field): add type: number * chore(number-field): remove hidden related code * fix(number-field): numeric value * chore(changeset): add changeset * feat(deps): add "@nextui-org/number-field" to docs * feat(react): export `@nextui-org/number-field` * feat(changeset): add @nextui-org/react * feat(docs): number-field examples * chore(number-field): use text instead * refactor(number-field): remove unnecessary filled-within * fix(number-field): test case * chore(number-field): remove aria-label for stepper buttons * feat(docs): add incrementAriaLabel & decrementAriaLabel to NumberField * chore(number-field): reorder WithFormatOptions * fix(deps): update number-field's peerDependencies & dependencies * feat(number-field): hidden input for holding numeric vaule * fix(docs): number field title * feat(docs): add format options to number field * chore(docs): revise number field content * chore(number-field): add type to useDOMRef * fix(number-field): clear button * fix(theme): clear button styles * refactor(theme): stepper button styles * chore(number-field): accept stepperButton class * fix(theme): helper wrapper padding * feat(deps): add `@react-aria/i18n` * fix(number-field): use locale from `@react-aria/i18n` * fix(deps): dependency order * fix(docs): incorrect command * chore(docs): remove type=number * chore(theme): add padding to stepper wrapper * fix(number-field): avoid resetting value * fix(number-field): storybook * chore(docs): remove custom impl * chore(docs): update docs code & content * chore(number-field): migrate to heroui * chore(number-field): migrate to heroui * chore(number-field): migrate to heroui * chore: rename to number input * fix(number-input): incorrect import * chore(docs): rename to number input * chore: change to number input * refactor(number-input): change label to amount * fix(docs): use heroui commands * chore(changeset): update package name * refactor(number-input): remove steps * refactor: remove helper text * feat(number-input): label placement * refactor(number-input): rename stepper * fix(theme): isClearable * feat(docs): add label placements * refactor(docs): update number-input content * fix(docs): incorrect file * feat(docs): add lablePlacement * refactor(docs): remove labelPlacement & startContent * refactor(docs): remove helperText * refactor(docs): remove helperText * refactor(docs): revise description * feat(number-input): add data-slot for stepper-wrapper * fix(number-input): test cases * fix(docs): unexpected change * refactor(number-input): update outdated info * fix(docs): coderabbitai comments * refactor: remove validationState * fix(docs): typo * chore(deps): remove unnecessary dep * chore(deps): bump RA versions * chore(number-input): apply latest labelPlacement change * refactor(number-input): update author * refactor(number-input): revise stepper wrapper alignment * refactor(number-input): stepper button styles * chore(number-input): add disableRipple * fix(theme): increase stepper button click area * fix(number-input): sync latest validationBehavior changes * fix(number-input): pass validationBehavior to useAriaNumberInput * chore(docs): add import react * chore(number-input): remove HorizontalStepper story * chore(number-input): enable ripple * fix(number-input): remove number type * refactor(theme): follow input clear button styles * feat(theme): add color for stepperButton * fix(theme): revise stepperButton size for outside & outside-left cases * fix(number-input): typo * chore(docs): update description for wheel * chore(theme): change opacity when pressed * chore(number-input): add disableRipple * Update .changeset/witty-flies-reflect.md * fix(theme): add hover opacity effect --------- Co-authored-by: Junior Garcia <[email protected]> * chore(docs): revised tags in doc routes for 2.7.0 (#4777) * chore(docs): remove last version update tags * chore(docs): add updated tag for 2.7.0 * chore(docs): updated table * chore(docs): update search meta * chore(docs): update github info * Merge branch 'canary' into docs/eng-2003 * chore(docs): update routes.json * chore(docs): update meta info * chore: improve theme builder * v2.7.0 * chore: v2.7.0 combined changeset * fix: changeset * fix: peer deps * feat: toast api improved * chore: toast styles improved * fix: toast styles * chore: toast width style changed * fix: changeset release * fix: changeset peerdeps * chore: toast styles improved * refactor(pagination): rtl (#4843) * refactor(pagination): rtl * chore(changeset): add changeset * feat: new spinner variant * fix(docs): popover shouldBlockScroll default value (#4851) * fix(select): select scroll content will close immediately when popover on click (#4849) * chore(select): update select deps * fix(select): select scroll content will close immediately when popover on click * chore(select): add .changeset file * chore(changeset): add issue number --------- Co-authored-by: աӄա <[email protected]> * feat(calendar): add firstDayOfWeek (#4852) * feat(calendar): add firstDayOfWeek * feat(docs): add firstDayOfWeek in Calendar docs * feat(calendar): add firstDayOfWeek to range calendar * feat(docs): add firstDayOfWeek to API table * feat: add firstDayOfWeek to date picker & date range picker * feat(docs): add firstDayOfWeek * feat(changeset): add changeset * feat: add firstDayOfWeek option in storybook * feat(docs): export firstDayOfWeek * chore(docs): update title * chore: spinner variants updated * feat: v2.7.0 blog * ci(changesets): version packages (#4601) Co-authored-by: Junior Garcia <[email protected]> * chore: manual release * fix(toast): fixing maxVisibleToasts, solid variant promise, promise timer (#4881) * fix: maxVisibleToasts functionality * chore: adding the changeset * fix: starting the toast timer when the promise is resolved * fix: spinner invisible in solid variants * fix(toast): shouldShowTimeoutProgess typo (#4858) * fix(toast): shouldShowTimeoutProgess typo * fix(toast): shouldShowTimeoutProgess typo * fix(select): pass form prop to hidden-select (#4854) * fix(select): pass form prop to hidden-select * chore(select): changeset * fix(spinner): Attempted to call useProviderContext() from the server (#4904) * fix(spinner): add banner in tsup.config.ts * chore(changeset): add changeset * chore(docs): update breaking changes in blog * chore(docs): handled in PR4905 * fix(number-input): onChange event in number input (#4907) * fix(number-input): onChange event in number input * chore(number-input): remove duplicate test case * fix(breadcrumb): broken start & end content (#4921) (#4922) * refactor: build process (#4909) * chore: update component description * chore: exclude stories-utils & test-utils * chore(utilities): remove unused info * chore(deps): pnpm-lock.yaml * fix: incorrect system & theme version in peerDependencies (#4901) * fix: incorrect system & theme version in peerDependencies * fix: incorrect system & theme version in peerDependencies * chore(changeset): add changeset * fix(changeset): remove `@heroui/stories-utils` and `@heroui/test-utils` from ignore list (#4939) * fix(docs): include .npmrc in sandbox (#4951) * fix(input): esc key to clear input value (#4892) * chore: theme generator credits * fix: blog date and spinner default variant * fix: #4850 Solve Pressing ESC doesn't clear input value * fix: #4850 code review change * fix: undo changes in apps/docs/content/blog/v2.7.0.mdx and add a test case for my changes * fix: run through the test cases successfully * fix: change md content * fix: using isClearable not clear the value * fix: add number-input clearable esc clear * fix: edit review problem * fix: delete unless file * chore(changeset): update changeset * fix: add inputProps.onKeyDown * fix: pressing ESC key in a read-only input not clear --------- Co-authored-by: Junior Garcia <[email protected]> Co-authored-by: աӄա <[email protected]> * ci(changesets): version packages (#4896) Co-authored-by: Junior Garcia <[email protected]> * v2.7.4 * chore(deps): bump turbo version (#4958) * chore(deps): bump turbo version * chore(root): update turbo.json * fix(docs): typecheck errors * fix(docs): typecheck errors * fix(deps): bump react-aria versions (#4998) * fix(deps): bump react-aria versions * chore(changeset): add changeset * chore(hooks): sync with RA's useButton * fix(use-aria-button): support aria-current * fix(docs): remove priority prop * fix(toast): remove priority queue & animation * fix(toast): remove deprecated logic * fix(popover): avoid passing preventFocusOnPress to non heroui button * fix: sync with UsePopover * fix(popover): prevent submenus from closing on scroll * fix(tests): test cases related to press refactoring * fix(toast): toast should appear above overlay and adding regionProps to ToastProvider (#5001) * fix: toast should be above the modal * fix: renaming the loadingIcon to loadingComponent * chore: adding changeset * chore: fixing conflicts * chore: adding the region props * fix: adding Marcus' suggestions * fix: marcus' suggestions * Revert "fix: renaming the loadingIcon to loadingComponent" This reverts commit 4c6bf32. * chore: adding marcus' suggestions * fix(number-stepper): stepper button pseudo height (#4968) * fix(progress): incorrect size in indeterminate storybook (#4967) * fix: shouldShowTimeoutProgress typo (#4961) * chore(workflows): update runner (#4960) * fix: a small eye icon for password input in edge(#4927) (#4950) * fix(progress): add RTL support to the progress component (#4911) * fix(progress): add RTL support to the progress component (#4908) * docs(progress): add changeset notes * refactor: resolved code review notes * refactor: removed unnecessary change * refactor: undo unnecessary change * fix: build * fix(toast): unexpected toast animation (#5003) * fix(deps): use RA beta toast * chore(toast): remove non-existing wrapUpdate * chore(changeset): add changeset * ci(changesets): version packages (#5002) Co-authored-by: Junior Garcia <[email protected]> * feat: open in chat button in doc examples (#4996) * feat: open in chat button in doc examples * feat: pass dependencies in open in chat * fix: open in chat error handling * chore: small adjustment --------- Co-authored-by: Junior Garcia <[email protected]> * chore: open in chat improvements * chore: remove ripple from the open in chat button * fix(docs): open in chat (#5018) * fix: open in chat ignore react imports * fix: open in chat utm params * fix: open in chat utm source * fix(docs): open in chat improvements (#5035) * fix(docs): parse dependency match imported components against heroui * fix(docs): center open in chat components * fix: open in new tab not working in ios (#5037) * fix(docs): dependency parse wrong react scope (#5043) * refactor(docs): remove unused variable in tailwind.config.js (#5070) * fix(root): add test timeout (#5071) * docs: sync api from heroui-cli v1.2.2 (#5111) Co-authored-by: GitHub Action <[email protected]> * chore(deps): bump RA versions (#5060) * chore(deps): bump RA versions * chore(root): add test timeout * fix(docs): remove misused color in listbox radio-group (#5011) Co-authored-by: WK Wong <[email protected]> * fix(number-input): add missing dependencies to stepper button props (#5097) * fix(input): revise styles in color type (#5098) * chore(input): include data-type * fix(input): input with type=color style * chore(toast): making toast compatible with latest RA (#5034) * chore: making the toast compatible with latest RA * fix: making the description prop as ReactNode * chore: updating toast docs * fix: fixing tests * chore(deps): update theme peerDependencies --------- Co-authored-by: WK Wong <[email protected]> Co-authored-by: Junior Garcia <[email protected]> * fix(docs): typo in `selectorIcon` for date and date range pickers (#5013) Co-authored-by: WK Wong <[email protected]> * fix(slider): slider display when `hideThumb` is `true` (#5087) * fix(slider): track fill start & end * fix(theme): revise slider display with `hideThumb` * fix(theme): handle isVertical case * fix(slider): handle range case * refactor(theme): simplify thumb related styles * chore(changeset): add changeset * chore(docs): update RA i18n version (#5122) * fix(toast): enable proper exit animations (#5121) * fix(toast): enable proper exit animations • Use LazyMotion and AnimatePresence in ToastProvider to support exit animations. • Simplify Toast by removing redundant LazyMotion wrapper. • Add motionProps to stories for easier animation customization. * chore(changeset): add changeset for ToastProvider exit animations * chore(toast): clean up stories by removing motionProps argument * chore(docs): revert `CONTRIBUTING.md` and `toast.stories.tsx`to initial state * chore: update stars count * fix(button): fixing the icon shift in safari (#5051) * fix: fixing the issue for icon shift in safari * chore: changing the solution to be cross browser compatible * chore: add twv4 docs * fix: codeblock on diff changes * refactor(docs): remove clearbit from remotePatterns (#5148) * fix(select): select label (#5147) * fix(select): label should be outside when there is a placeholder * fix(theme): remove pointer-events-none & revise style when there is helper * chore(changeset): add changeset * fix(select): add hasLabelOutside * fix(theme): pointer-events * fix(select): revise hasLabelOutside * fix(use-data-scroll-overflow): missing checkOverflow (#5139) * fix(tooltip): tooltip stays open on fast movement (#4482) * fix(components): fix tooltip staying open, add keys, fix AnimatePresence * chore(changeset) add changeset for tooltip retention fix * chore(changeset) update changeset text based on codebrabbit feedback * chore(changeset): update changset message * fix(tooltip): lint * chore(changeset): update package name * fix(tooltip): change LazyMotion level, specify keys * Merge branch 'canary' into pr/4482 * chore(tooltip): clean up code structure * Merge branch 'canary' into pr/4482 --------- Co-authored-by: աӄա <[email protected]> * ci(changesets): version packages (#5120) Co-authored-by: Junior Garcia <[email protected]> --------- Co-authored-by: աӄա <[email protected]> Co-authored-by: millmason <[email protected]> Co-authored-by: winches <[email protected]> Co-authored-by: Maharshi Alpesh <[email protected]> Co-authored-by: Peterl561 <[email protected]> Co-authored-by: Paul Ebose <[email protected]> Co-authored-by: Zarin <[email protected]> Co-authored-by: Shrinidhi Upadhyaya <[email protected]> Co-authored-by: Avan <[email protected]> Co-authored-by: Vincentius Roger Kuswara <[email protected]> Co-authored-by: Ryo Matsukawa <[email protected]> Co-authored-by: Praharsh Bhatt <[email protected]> Co-authored-by: Adrian Szarapow <[email protected]> Co-authored-by: Hova25 <[email protected]> Co-authored-by: Hovannes Markarian <[email protected]> Co-authored-by: Tsuki <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Steve Mosley <[email protected]> Co-authored-by: LinYongLu <[email protected]> Co-authored-by: Waleed Asender <[email protected]> Co-authored-by: KKKKKK <[email protected]> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: yerim <[email protected]> Co-authored-by: Aymeric Wibo <[email protected]> Co-authored-by: Alexander Gavrilenko <[email protected]> Co-authored-by: Connor Elsea <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5033
📝 Description
⛳️ Current behavior (updates)
🚀 New behavior
💣 Is this a breaking change (Yes/No):
📝 Additional Information
Summary by CodeRabbit
New Features
Style
Chores
Documentation