Improved download client features #958
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces the following features to the `download_file` utility function: - Configurable timeouts & retries - OTel tracing of requests - Sync/async usage - Platform certificate store support - Consistent output via `bullet_stream` This replaces the usage of `ureq` as the HTTP client library so it wasn't possible to make this change fully backwards-compatible as the previous `DownloadError` enum leaked this internal implementation detail. The `download_file` function is also marked as deprecated. It should be replaced with the following which offers a bit more flexibility: ```rust get(uri.as_ref()) .call_sync() .and_then(|res| res.download_to_file_sync(destination)); ```
…t_stream` features are enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the
httpfeature which provides a consistent methods to makeGETrequests:http::get(...)http::get(...).call().and_then(|res| res.download_to_file(path))http::bullet_stream_request_logger()bullet_streamfeature is also enabledbullet_stream