[BUG] Make AnimeEffects work with dark desktop theme

[larpon]

I recently changed to a dark desktop theme and, while still usable, AnimeEffects has a few quirks in this direction:

[herace]

Oh wow, never knew AnimeEffects do something like that...this can put some people off. A sleek Dark-Theme for AnimeEffects will be excellent and draw more people in using this app.

Honestly speaking im not sure how QT handles the UI theme based on the users current Desktop Environment window scheme / color pallet. 😞

[larpon]

Yeah. Rumour has it that QtWidgets is a bit broken in this area (QML should work better with system provided themes) and that we maybe need to build an explicit dark theme for users to switch to. I've been talking to @azagaya and @Jose-Moreno about it on Discord / IRC (you're welcome to pop by and say hello!)

[larpon]

Hmm.. It might be the hardcoded styles in data/stylesheet - it might be enough to simply remove any hardcoded colors?

[azagaya]

Hi! i think that actually we should add some hardcoded colors, to override what is set up by the system. I could try if you give me a list of the widgets that have this issue.. I see spinboxes are affected, aren't they?

[larpon]

We can get far by simply removing hard coded colors and do some tweaking in the code base:

There's still quite a bit of hard coded colors in there.

As @azagaya and I has discussed - it's probably worth it to include theme support and include 3-4 styles:

• System/Default (Use system provided styles. Should work with both light & dark system themes as opposed to current mixture)
• Classic/Original (The current theme)
• Light (a more modern take on the classic)
• Dark (a modern dark theme)

[larpon]

... just suggestions - but I'd like to be able to at least use it with a dark system theme :)

[larpon]

I made a quick test branch here:
https://github.com/Larpon/AnimeEffects/tree/test/remove-all-hard-coded-colors

(Will need a dark system theme)

[larpon]

Fixed in #16