Skip to content

Support overwriting scope blocks #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support overwriting scope blocks #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/has_scope.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ def has_scope(*scopes, &block)

options[:only] = Array(options[:only])
options[:except] = Array(options[:except])
options[:block] = block if block

self.scopes_configuration = scopes_configuration.dup

Expand Down
8 changes: 8 additions & 0 deletions test/has_scope_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,9 @@ def default_render

class BonsaisController < TreesController
has_scope :categories, if: :categories?
has_scope :content do |controller, scope|
scope.by_content('some other content')
end

protected
def categories?
Expand Down Expand Up @@ -483,6 +486,11 @@ def test_overwritten_scope
assert_equal(:categories?, BonsaisController.scopes_configuration[:categories][:if])
end

def test_overwritten_scope_with_block
assert_nil(TreesController.scopes_configuration[:content][:block])
assert(BonsaisController.scopes_configuration[:content][:block])
end

protected

def mock_tree(stubs = {})
Expand Down