Do not set unlock_token attribute to undigested value after unlocking user with token #5779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
User.unlock_access_by_tokenis used, Devise unlocks access to the user, and sets theunlock_tokenattribute to the original non-digested token, passed as an argument. If we are to set any other attributes on the unlocked user and save the record, the non-digested token is persisted in the database.This does not seem to pose any security risks (at least I cannot find any), but I also see no benefit in such behaviour.
History
The change was originally introduced in 354e502 to both
LockableandConfirmable, with insecure token lookups removed in 6b3b0c5, and digests removed fromConfirmablein eb640ed.