-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Make test suite work #5770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make test suite work #5770
Conversation
cc6453a to
af7f23a
Compare
|
@gregmolnar can the tests and rails version support split into two PRs? |
|
No, because the test don't pass and it doesn't make sense to make them pass for versions of Ruby and Rails that Devise shouldn't support anymore. |
|
@carlosantoniodasilva These still pass locally with ruby 3.2 and 3.3. If this gets merged, I can look into the issues with 3.4 |
|
@gregmolnar thanks for this. I was originally considering only dropping support to Rails < 6 in Devise, regardless of Rails currently supported versions. But that's been a while, and I've already dropped support for Rails < 7 and Ruby < 2.7 on other heartcombo/* libs (was gonna get to Devise next/soon), so I think we should stick to that same level of support for Devise here, if you don't mind. What's in main is already cutting down multiple versions (currently released version supports all the way back to 4.1), so let's at least leave the last 2 majors on the table; cut down v4/5/6, and continue supporting v7.0+ for the time being. This is |
|
@carlosantoniodasilva I made the test matrix the same and added back Rails 7.0 support. Can you approve the workflow to see if the whole matrix succeeds? Thanks! |
7c2b74f to
db5f683
Compare
|
@carlosantoniodasilva I fixed the issues, it passes on my fork now: https://github.com/gregmolnar/devise/actions/runs/18576202141 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! just had a couple minor suggestions, but mainly pointing Gemfile to Rails v8.1.0.rc1 since we have v8.0 already tested by other.
|
Thank you! ❤️💜💛💚💙 |
The tests on main are not passing with Rails 7.1 onwards.
At the same time, since Rails is supported 7.2 onwards and Ruby 3.1 is EOL in 2 weeks, we can drop support for older versions.