Skip to content

Conversation

@gregmolnar
Copy link
Contributor

@gregmolnar gregmolnar commented Mar 16, 2025

The tests on main are not passing with Rails 7.1 onwards.
At the same time, since Rails is supported 7.2 onwards and Ruby 3.1 is EOL in 2 weeks, we can drop support for older versions.

@gregmolnar gregmolnar marked this pull request as ready for review March 16, 2025 16:20
@gregmolnar gregmolnar force-pushed the tests branch 2 times, most recently from cc6453a to af7f23a Compare March 16, 2025 16:43
@fthobe
Copy link

fthobe commented Mar 21, 2025

@gregmolnar can the tests and rails version support split into two PRs?

@gregmolnar
Copy link
Contributor Author

gregmolnar commented Mar 21, 2025

No, because the test don't pass and it doesn't make sense to make them pass for versions of Ruby and Rails that Devise shouldn't support anymore.

@gregmolnar
Copy link
Contributor Author

@carlosantoniodasilva These still pass locally with ruby 3.2 and 3.3. If this gets merged, I can look into the issues with 3.4

@carlosantoniodasilva
Copy link
Member

carlosantoniodasilva commented Oct 16, 2025

@gregmolnar thanks for this.

I was originally considering only dropping support to Rails < 6 in Devise, regardless of Rails currently supported versions. But that's been a while, and I've already dropped support for Rails < 7 and Ruby < 2.7 on other heartcombo/* libs (was gonna get to Devise next/soon), so I think we should stick to that same level of support for Devise here, if you don't mind.

What's in main is already cutting down multiple versions (currently released version supports all the way back to 4.1), so let's at least leave the last 2 majors on the table; cut down v4/5/6, and continue supporting v7.0+ for the time being.

This is responders setup, for reference: heartcombo/responders@818ec07

@gregmolnar
Copy link
Contributor Author

@carlosantoniodasilva I made the test matrix the same and added back Rails 7.0 support. Can you approve the workflow to see if the whole matrix succeeds? Thanks!

@gregmolnar gregmolnar force-pushed the tests branch 6 times, most recently from 7c2b74f to db5f683 Compare October 16, 2025 22:09
@gregmolnar
Copy link
Contributor Author

Copy link
Member

@carlosantoniodasilva carlosantoniodasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! just had a couple minor suggestions, but mainly pointing Gemfile to Rails v8.1.0.rc1 since we have v8.0 already tested by other.

@carlosantoniodasilva carlosantoniodasilva merged commit dbc8e77 into heartcombo:main Oct 21, 2025
34 checks passed
@carlosantoniodasilva
Copy link
Member

Thank you! ❤️💜💛💚💙

carlosantoniodasilva added a commit that referenced this pull request Oct 21, 2025
Update bundle to avoid 3.4 mutex_m require error.

Test against Rails 7.0 branch which contains Ruby 3.4 fixes.

Update changelog to mention Rails < 7.0 support being dropped.

Builds on top of #5770
Closes #5776
Closes #5761
@gregmolnar gregmolnar deleted the tests branch October 22, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants