GitHub action react project #8
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is needed on your end:
To have this work
You can see this working on the pull request that is my fork of the project
since the secret has been set for the repository:
MichaelDimmitt#1
Summary:
I got this working first on an Angular project.
scratch-angular-at-different-versions/scratch-angular-thirteen-three-one#1
^ If you click view-details you can see the lighthouse run
React is easier to achieve.
Note: these changes come from the easy config instructions from the lighthouse-ci documentation.
recommended-configurations
Here is the link to the github app:
https://github.com/apps/lighthouse-ci
Final Note,
I removed the assertions,
The presets were causing the build to fail
I guess an alternate to it would be to add thresholds or set off to all of the rules that were failing for this particular version of create react app.
If you click view-details you can see the lighthouse run:
