Skip to content

Conversation

MichaelDimmitt
Copy link
Contributor

What is needed on your end:

To have this work

  1. you need to add the token as a secret in the organization.
  2. or as a secret in the repository.

You can see this working on the pull request that is my fork of the project
since the secret has been set for the repository:

MichaelDimmitt#1

Summary:

I got this working first on an Angular project.

scratch-angular-at-different-versions/scratch-angular-thirteen-three-one#1
^ If you click view-details you can see the lighthouse run

React is easier to achieve.

Note: these changes come from the easy config instructions from the lighthouse-ci documentation.

recommended-configurations

Here is the link to the github app:
https://github.com/apps/lighthouse-ci

Final Note,

I removed the assertions,

The presets were causing the build to fail
I guess an alternate to it would be to add thresholds or set off to all of the rules that were failing for this particular version of create react app.

If you click view-details you can see the lighthouse run:
Screen Shot 2022-04-03 at 9 59 27 PM

@MichaelDimmitt
Copy link
Contributor Author

Travis CI is failing because I do not have it setup for my repo.

But should work if still setup on your project.

Screen Shot 2022-04-04 at 12 39 31 AM

@MichaelDimmitt
Copy link
Contributor Author

resolves: #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant