-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Ladies and gentlemen, introducing hulypulse-client and Typing #9778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Connected to Huly®: UBERF-13487 |
bd806ff
to
97718c2
Compare
plugins/chunter-resources/src/components/ChannelTypingInfo.svelte
Outdated
Show resolved
Hide resolved
plugins/chunter-resources/src/components/ChannelTypingInfo.svelte
Outdated
Show resolved
Hide resolved
plugins/chunter-resources/src/components/ChannelTypingInfo.svelte
Outdated
Show resolved
Hide resolved
const room = { objectId: object._id, objectClass: object._class } | ||
const typing = { person: me, lastTyping: Date.now() } | ||
updateMyPresence(room, { typing }) | ||
setTyping(me) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not correct, objectId
is missing, this will show that you are typing in every channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Это очень правильное замечание.
Я поменял setTyping и learTyping, передаю (me, String(object._id))
Поменял соответствующие функции.
Но возникла проблема с подпиской. Подписка инициируется из:
platform/plugins/chunter-resources/src/components/ChannelTypingInfo.svelte
Подписка инициируется так:
onMount(() => {
subscribeTyping(handleTypingInfo, String(object._id))
})
Но в этом разделе нет object, и откуда он появляется и где его взять, я не знаю. Тут мне потребуется помощь авторов кода.
Signed-off-by: Leonid Kaganov <[email protected]>
return reply.result || '' | ||
} | ||
|
||
public async subscribe<T>(key: string, callback: Callback): Promise<() => Promise<boolean>> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
callback: Callback
hulypulse-client and its first use for the Typing service.
I had to move the hulypulse-client daemon port to 8099 because 8095 was already occupied by something in our system.