Find ssh commands via locate #1983
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uenz
force-pushed
the
feature/LocateSSHCommands
branch
from
2004997 to
210ac0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SparkleShare uses several comandline tools to provide functionality. While working on the windows version i saw that ssh, ssh-keygen and ssh-keyscan was hard coded and sparkleshare expects that these are in the path. This is not always given.
I extended the SSHCommand.cs to da the location of all ssh related commands. The additional calls in BaseController.cs checks for existance of the shs commands. As ssh-keyscan and ssh-keygen does not provide a version info they are called to check if they are there.
The enquating is changed from ' to ", because this is the platform independent way.