-
-
Notifications
You must be signed in to change notification settings - Fork 138
Add new themes introduced in @node-red-contrib-themes/theme-collection v4.1 #2095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe documentation and configuration schema for the Node-RED Home Assistant add-on were updated to expand the list of available UI themes. Multiple new themes were added to both the documentation and the configuration schema, increasing the customization options for users. No code or functional changes were made. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Marking as "ready for review". The release of Node-RED v4.1 seems imminent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
node-red/config.yaml (1)
52-52
: List grows—consider maintainability toolingThe ever-expanding regex list is becoming unwieldy and error-prone to edit manually. A small helper (e.g. a CI job that fetches the latest theme names from
@node-red-contrib-themes/theme-collection
and regenerates this line) would prevent future typos/omissions and keep schema & docs in sync automatically.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
node-red/DOCS.md
(1 hunks)node-red/config.yaml
(1 hunks)
🔇 Additional comments (1)
node-red/DOCS.md (1)
126-150
: Docs in sync—looks goodNew theme bullets match the schema exactly and remain alphabetically ordered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks, @bonanitech 👍
../Frenck
Proposed Changes
Node-RED Contrib Theme Collection version 4.1 introduced new themes:
This PR adds them to the add-on config.
Related Issues
Summary by CodeRabbit