This repository was archived by the owner on Sep 20, 2023. It is now read-only.
add strict family function and function to get file extensions #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| -- this is unsafe and is mainly needed for testing purpose | ||
| unsafeFileName :: ByteArray -> FileName | ||
| unsafeFileName = FileName | ||
|
|
There was a problem hiding this comment.
I don't think this should be part of this PR; not quite harmful though
|
Thanks @littc for implementing the initial things ! and @NicolasDP for rebasing ! |
|
Thanks for the mentoring @NicolasDP and @vincenthz! On 25 July 2016 at 22:26, Vincent Hanquez [email protected] wrote:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #16 and partially fix #35
this PR is a clean version (rebased) of #49