error-stack remove special casing of Location for formatting
#1237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/libs > error-stack
`Location` is now only special cased in `fmt`, like it was before, but now one can set hooks.
TimDiekmann
requested changes
Oct 24, 2022
Co-authored-by: Tim Diekmann <[email protected]>
Co-authored-by: Tim Diekmann <[email protected]>
TimDiekmann
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌟 What is the purpose of this PR?
This removes the special casing currently used to display the source location of a
Context.🔗 Related links
🔍 What does this change?
Locationlogic into hookInstruction::Symbolvariant)provide location for frames on(reverted in 38dbd4e)nightlyviaProvideAPInew(reverted in 38dbd4e)FrameTypeandAttachmentType, which act as marker equivalents toFrameKindandAttachmentKindrespectively📜 Does this require a change to the docs?
No, as this special casing was never explained to the user.
We may want to add docs about nightly provide API vs. stable downcast.
🛡 What tests cover this?
The existing tests should not fail.
📋 ToDo
Locationhook.