[UI] - Glimmerize b64-toggle component #31423
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the start of refactoring out all usage of
@ember/component
. I took the refactoring work as a chance to use Copilot more. It does a pretty good job on converting things (especially with the custom instructions I've included, more about them in a minute). The biggest issue was re-working this component so that the data flow was uni-directional which also necessitated some updates to the usage sites.https://hashicorp.atlassian.net/browse/VAULT-38592
Copilot usage
I built off of the work @beagins did for the hackweek. In addition to that I added an instruction which was copy and pasting the upgrading to Octane docs from Ember's guide site here: https://github.com/ember-learn/guides-source/tree/master/guides/v5.9.0/upgrading/current-edition
This meant Copilot could get really far. I opened the
b64-toggle.js
component and prompted Copilot with "Convert this file to a glimmer component".TODO only if you're a HashiCorp employee
backport/
label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x
, but older release branches will bebackport/ent/x.x.x+ent
.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.
PCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.