Skip to content

Conversation

meirish
Copy link
Collaborator

@meirish meirish commented Aug 4, 2025

Description

This is the start of refactoring out all usage of @ember/component. I took the refactoring work as a chance to use Copilot more. It does a pretty good job on converting things (especially with the custom instructions I've included, more about them in a minute). The biggest issue was re-working this component so that the data flow was uni-directional which also necessitated some updates to the usage sites.

https://hashicorp.atlassian.net/browse/VAULT-38592

Copilot usage

I built off of the work @beagins did for the hackweek. In addition to that I added an instruction which was copy and pasting the upgrading to Octane docs from Ember's guide site here: https://github.com/ember-learn/guides-source/tree/master/guides/v5.9.0/upgrading/current-edition

This meant Copilot could get really far. I opened the b64-toggle.js component and prompted Copilot with "Convert this file to a glimmer component".

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.

Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@meirish meirish requested review from a team as code owners August 4, 2025 21:00
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Aug 4, 2025
Copy link

github-actions bot commented Aug 4, 2025

Build Results:
All builds succeeded! ✅

Copy link

github-actions bot commented Aug 4, 2025

CI Results:
All Go tests succeeded! ✅

@meirish meirish force-pushed the glimmerize-b64-toggle branch from f7f1345 to 65daaff Compare August 4, 2025 22:08
Copy link

vercel bot commented Aug 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vault-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2025 2:01am

@meirish meirish added this to the 1.20.2 milestone Aug 4, 2025
@meirish meirish changed the title Glimmerize b64 toggle [UI] - Glimmerize b64 toggle Aug 4, 2025
@meirish meirish changed the title [UI] - Glimmerize b64 toggle [UI] - Glimmerize b64-toggle component Aug 4, 2025
@meirish meirish force-pushed the glimmerize-b64-toggle branch from 65daaff to 6026776 Compare August 5, 2025 02:00
@tomcf-hcp tomcf-hcp modified the milestones: 1.20.2, 1.20.3 Aug 7, 2025
@meirish meirish merged commit 32e806f into main Aug 12, 2025
46 checks passed
@meirish meirish deleted the glimmerize-b64-toggle branch August 12, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants