fix kms config overrides #31090
Open
fix kms config overrides #31090
+90
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Fixes #24114 |
|
tested in my environment on 1.19.0, worked as expected |
Slevy35
force-pushed
the
fix-config-override
branch
from
6832619 to
380504b
Compare
|
any update? |
Slevy35
force-pushed
the
fix-config-override
branch
from
380504b to
c4056e4
Compare
None yet - I apologize, and thank you for your patience. I'll see if I can nudge this along. |
Slevy35
force-pushed
the
fix-config-override
branch
from
c4056e4 to
76161df
Compare
|
what can we do to push this? it blocks us from upgrading vault |
Slevy35
force-pushed
the
fix-config-override
branch
from
76161df to
958c3d4
Compare
Slevy35
force-pushed
the
fix-config-override
branch
from
958c3d4 to
b872c1e
Compare
|
@Slevy35 is attempting to deploy a commit to the HashiCorp Team on Vercel. A member of the Team first needs to authorize it. |
Slevy35
force-pushed
the
fix-config-override
branch
from
b872c1e to
023b07f
Compare
|
any updates? |
Slevy35
force-pushed
the
fix-config-override
branch
from
023b07f to
8f54553
Compare
|
can someone please review?? @heatherezell |
Slevy35
force-pushed
the
fix-config-override
branch
from
8f54553 to
6b3e848
Compare
|
Hi there - I'm sorry for the delay. I've flagged this and will bring it up at our next planning session, which will be on Tuesday. Please do feel free to ping me next week if you don't hear anything. I really appreciate your patience, and apologize again for how long this is taking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix awskms config override with env vars, which cause issues when the kms key is in a different region then the current one.