Add limit to JSON nesting depth #31069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
guygrigsby
reviewed
Jun 23, 2025
helper/json/complex_json.go
Outdated
| "strings" | ||
| ) | ||
|
|
||
| func GenerateComplexJSON(depth int) string { |
There was a problem hiding this comment.
I don't see this being used. Seems like a great function to use in unit tests.
sdk/helper/jsonutil/json.go
Outdated
| } | ||
|
|
||
| // This function avoids building the full map in memory, suitable for very deep JSON. | ||
| func calculateMaxDepthStreaming(jsonReader io.Reader) (int, error) { |
There was a problem hiding this comment.
We may be able to benefit from writing unit tests that use both generated JSON data and known challenging JSON data. That' s not to say the function is wrong, I don't think it is, rather to say it can't hurt to be sure.
biazmoreira
force-pushed
the
biazmoreira/VAULT-36788
branch
from
1f938e6 to
c32da58
Compare
|
CI Results: |
biazmoreira
force-pushed
the
biazmoreira/VAULT-36788
branch
from
6316e2e to
7719c10
Compare
biazmoreira
force-pushed
the
biazmoreira/VAULT-36788
branch
from
7719c10 to
70a50cd
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
miagilepner
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add limit to JSON nesting depth
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.