Skip to content

add role to alias metadata #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add role to alias metadata #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1afed4c
add role to alias metadata
msonnleitner Jan 23, 2025
e2adcc3
add role as reservedAliasMetadataKey
msonnleitner Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion path_login.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,15 @@ const (
metadataKeySAName = "service_account_name"
metadataKeySANamespace = "service_account_namespace"
metadataKeySASecretName = "service_account_secret_name"
metadataKeyRole = "role"
)

var reservedAliasMetadataKeys = map[string]struct{}{
metadataKeySAUID: {},
metadataKeySAName: {},
metadataKeySANamespace: {},
metadataKeySASecretName: {},
metadataKeyRole: {},
}

// defaultJWTIssuer is used to verify the iss header on the JWT if the config doesn't specify an issuer.
Expand Down Expand Up @@ -205,6 +207,7 @@ func (b *kubeAuthBackend) pathLogin(ctx context.Context, req *logical.Request, d
metadata[metadataKeySAName] = sa.name()
metadata[metadataKeySANamespace] = sa.namespace()
metadata[metadataKeySASecretName] = sa.SecretName
metadata[metadataKeyRole] = roleName

auth := &logical.Auth{
Alias: &logical.Alias{
Expand All @@ -219,7 +222,7 @@ func (b *kubeAuthBackend) pathLogin(ctx context.Context, req *logical.Request, d
metadataKeySAName: sa.name(),
metadataKeySANamespace: sa.namespace(),
metadataKeySASecretName: sa.SecretName,
"role": roleName,
metadataKeyRole: roleName,
},
DisplayName: fmt.Sprintf("%s-%s", sa.namespace(), sa.name()),
}
Expand Down
12 changes: 12 additions & 0 deletions path_login_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -885,6 +885,18 @@ func TestLoginEntityAliasMetadataAssignment(t *testing.T) {
t.Fatalf("expected value %q got %q for key %q", expV, v, expK)
}
}

expK := "role"
expV := data["role"]
v, ok := resp.Auth.Alias.Metadata["role"]

if !ok {
t.Fatalf("expected key %q not found", expK)
}

if v != expV {
t.Fatalf("expected value %q got %q for key %q", expV, v, expK)
}
}

func TestAliasLookAhead(t *testing.T) {
Expand Down