Update box add action to pass arch correctly #13699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…added from a file
…added from a file test(action/box_add): Update tests to ensure box arch is passed down correctly
taru-garg-hashicorp
force-pushed
the
taru-garg-hashicorp/test-bento
branch
from
480ed60 to
8ec3d69
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the box add action where the wrong environment variable was being used to pass architecture information. The fix ensures that box_architecture (which is set in the Vagrantfile) is correctly passed to the add_direct method instead of the non-existent architecture variable.
- Changes the architecture parameter from
env[:architecture]toenv[:box_architecture]in theadd_directmethod call - Adds test coverage to verify the architecture is correctly passed through to the box collection
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/vagrant/action/builtin/box_add.rb | Updates the add_direct method to use the correct box_architecture environment variable |
| test/unit/vagrant/action/builtin/box_add_test.rb | Adds test coverage to verify architecture is properly passed to the box collection |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, during the box add action
env[:architecture]gets passed down toadd_direct, however, there is noarchitecturein env, the correct arch which is set inVagrantfileisbox_architecture, this PR changes the action to pass down the correct parameterCloses: #13698, #13697