fix(random_password & random_string): CreateString is not generating valid strings #742
+39
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
1 task
kstiehl
changed the title
Signed-off-by: kstiehl <[email protected]>
kstiehl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes: #741
Description
Currently the
random_passwordresource allows to override the special characters. Terraform strings are UTF-8 because golang strings are UTF-8. When a user passes a character like german umlauts or other characters commonly used in the EU (€,ñ,ç,°ä,ü,ö,ß) theCreateStringfunctions butchers these because it is taking random bytes out of the allowed inputs. However all these character are multi byte UTF-8 character.