-
Notifications
You must be signed in to change notification settings - Fork 36
TFECO-9502: chore: update protobuf definitions to include actions rpcs and messages #513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d3c5f13 to
3c4cf49
Compare
|
#512 was reverted so I'll have to rebase this one once more (when that PR is re-reverted :D) |
|
rebased it onto #522 |
dd82eea to
74f8bdc
Compare
|
converted to draft to adjust to latest protocol changes |
398b6ba to
19c1ae7
Compare
19c1ae7 to
5eff9bc
Compare
SBGoods
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Selena Goods <[email protected]>
b621e6b to
f4d2964
Compare
austinvalle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SBGoods Updated the PR with the latest proposed protocol (assuming the metadata changes are agreed upon, but we can adjust those later if we have more changes 👍🏻 )
I need another approval I think because I was the last commit 😆
Related Issue
N/A
Description
Updated the protofbuf definitions based on hashicorp/terraform#37006
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.