e2e Rdp client tests #3055
Open
e2e Rdp client tests #3055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
DhariniJeeva
reviewed
Nov 7, 2025
| return true; | ||
| } else if (process.platform === 'darwin') { | ||
| const result = execSync( | ||
| ['kMDItemCFBundleIdentifier == "com.microsoft.rdc.macos"'], |
Collaborator
There was a problem hiding this comment.
I'm not sure the execSync call would work as intended here. I think it should be
const result = execSync(
'mdfind "kMDItemCFBundleIdentifier == \'com.microsoft.rdc.macos\'"',
{ encoding: 'utf-8' }
);
return result && result.trim().length > 0;
| {}, | ||
| 'mdfind', | ||
| ); | ||
| console.log('mdfind result:', result.result.toString()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add e2e test for RDP client launch.
Note: RDP tests require a mac/windows runner in CI. Currently, we only have Ubuntu runner setup so it wont validate these tests. Skipping these tests until we set a new runner.
🎟️ Jira ticket
Screenshots (if appropriate)
How to Test
Run the e2e tests locally using this branch.
Checklist
a11y-testslabel to run a11y audit tests if neededPCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.