Expose Chosen to the window object. #929
Conversation
|
good for me |
|
btw, does the SelectParser and AbstractChosen really need to be exposed as global variables ? Couldn't we do the scoping of Chosen around the whole compiled file instead of doing it separately for each coffee file ? |
|
You could even make it this: |
|
I agree that we should not expose those methods. When we start switching the build method (to Grunt), we should make that change as well. |
Expose Chosen to the window object.
Includes these Pull Requests: - #902 Fiexd Firefox mousedown drag issue - #914 Handle select title - #916 Fixed the handling of ctrl key for multiple select - #920 Fixed multiple select placeholder clipping bug - #929 Expose Chosen to the window object Refer to these pull requests for details and diffs.
|
Hey @pfiller what do you think about adding AMD support so that chosen is not polluting the window or jQuery objects. I have created a pull request for that but just for the jQuery version. I can change that for the prototype as well. It does require a build change though. |
|
Hi @angelyordanov - I saw your pull and plan to give it a proper look-over before offering an opinion. I'm not super familiar with how AMD works, so I'll need to take some time and familiarize myself. Chosen has a ton of open issues and we're very slowly digging ourselves out of the hole. Thanks for being patient. |
Fixes #924
The Prototype version exposes the Chosen class because that's the only way to use it. The jQuery version doesn't typically need to do that because usage goes through jQuery itself. This means that if you want to extend the class or something, you'd have to do it in the Chosen source.
@stof @jkintscher This just mirrors the Prototype version and should be of minimal consequence. It exposes another global variable, but that's about the extent of its impact.