Skip to content

feat: add support for configuring transparent hugepages #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tserong
Copy link

@tserong tserong commented Jul 21, 2025

Summary

This adds the ability to configure some transparent hugepage settings, and see some extra meminfo status for each node.

This is largely @m-ildefons' earlier work from https://github.com/m-ildefons/harvester-dashboard/tree/wip/hugepages, re-applied to harvester-ui-extension.

Note: this requires harvester/node-manager#87

PR Checklists

Related Issue

harvester/harvester#5006

Test screenshot or video

Host Details:

image

Host Configuration:

image

Co-authored-by: Moritz Röhrich <[email protected]>
Signed-off-by: Tim Serong <[email protected]>
@a110605
Copy link
Collaborator

a110605 commented Jul 21, 2025

Is this page only available after v1.6.0 ?

If yes, please add a new feature flag in /harvester-ui-extension/pkg/harvester/config/feature-flags.js. Then we won't show the HugePages tab if harvester version is lower than v1.6.0

Use below getter to determine if the feature flag is enabled on certain harvester version.

kubeovnVpcSubnetSupport(){
    return this.$store.getters['harvester-common/getFeatureEnabled']('kubeovnVpcSubnet');
}

@tserong tserong marked this pull request as draft July 22, 2025 02:14
@tserong
Copy link
Author

tserong commented Jul 22, 2025

Is this page only available after v1.6.0 ?

Actually it's just been moved to v1.7.0, so I've marked this PR a draft for now. Thanks for the tip about adding a feature flag though! I'll definitely want to add that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants