Skip to content

Feat: Display name support #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 18, 2023
Merged

Feat: Display name support #359

merged 2 commits into from
Aug 18, 2023

Conversation

Bloxs
Copy link
Contributor

@Bloxs Bloxs commented Aug 11, 2023

About

This adds discord's display name property to the user class and also changes tag to return their "handle" if they don't have a discriminator

Status

  • These changes have been tested against Discord API or do not contain API change.
  • This PR includes only documentation changes, no code change.
  • This PR introduces some Breaking changes.

Helloyunho
Helloyunho approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@Helloyunho Helloyunho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Helloyunho Helloyunho merged commit 1a21e7a into harmonyland:main Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Helloyunho Helloyunho Helloyunho approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Bloxs @Helloyunho