Skip to content

Conversation

tfo-dot
Copy link
Contributor

@tfo-dot tfo-dot commented Mar 26, 2023

About

This also fix invalid typings for some files

Status

  • These changes have been tested against Discord API or do not contain API change.
  • This PR includes only documentation changes, no code change.
  • This PR introduces some Breaking changes.

Copy link
Member

@Helloyunho Helloyunho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, check my comment and fix prettier error


function queryString<T>(obj: T): string {
// deno-lint-ignore no-explicit-any
function queryString<T extends {[key: string]: any}>(obj: T): string {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use unknown instead of any

Copy link
Member

@Helloyunho Helloyunho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants