Skip to content

feat: add audit log create event #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2023
Merged

feat: add audit log create event #341

merged 1 commit into from
Feb 26, 2023

Conversation

Blockzilla101
Copy link
Contributor

About

This pr implements audit log create event.

Status

  • These changes have been tested against Discord API or do not contain API change.
  • This PR includes only documentation changes, no code change.
  • This PR introduces some Breaking changes.

noticed that typings for AuditLogEntry were incorrect, im not really sure if i should fix them in this pr or not or if they are supposed to be like that

Helloyunho
Helloyunho approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@Helloyunho Helloyunho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! it's strange that Discord didn't document the guild_id property
maybe they just forgot about it

@Helloyunho Helloyunho merged commit 5b86dbb into harmonyland:main Feb 26, 2023
@Blockzilla101 Blockzilla101 deleted the add-events branch February 26, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Helloyunho Helloyunho Helloyunho approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Blockzilla101 @Helloyunho