Skip to content

Update client.ts #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 9, 2022
Merged

Update client.ts #330

merged 3 commits into from
Nov 9, 2022

Conversation

nyxoy44
Copy link
Contributor

@nyxoy44 nyxoy44 commented Nov 9, 2022 •
edited
Loading

About

changed CommandClient#.isUserBlacklisted(guildID: string) to CommandClient#.isUserBlacklisted(userD: string)

Status

  • These changes have been tested against Discord API or do not contain API change.
  • [ x ] This PR includes only documentation changes, no code change.
  • This PR introduces some Breaking changes.

Helloyunho
Helloyunho requested changes Nov 9, 2022
View reviewed changes
Copy link
Member

@Helloyunho Helloyunho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my god I'm embarrassed that we made this mistake
after a minor typo fix I think it's good to go

src/commands/client.ts Outdated
isGuildBlacklisted?: (guildID: string) => boolean | Promise<boolean>
/** Method to check if certain User is blacklisted from using Commands. */
isUserBlacklisted?: (guildID: string) => boolean | Promise<boolean>
isUserBlacklisted?: (userdID: string) => boolean | Promise<boolean>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

userd..?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i mean userID

src/commands/client.ts Outdated
isGuildBlacklisted: (guildID: string) => boolean | Promise<boolean>
isUserBlacklisted: (guildID: string) => boolean | Promise<boolean>
isChannelBlacklisted: (guildID: string) => boolean | Promise<boolean>
isUserBlacklisted: (userdID: string) => boolean | Promise<boolean>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also in here

@Helloyunho
Copy link
Member

oh right fix the lint error too

nyxoy44
nyxoy44 commented Nov 9, 2022
View reviewed changes
Copy link
Contributor Author

@nyxoy44 nyxoy44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed userdID to userID

@Helloyunho
Copy link
Member

changed userdID to userID

nice, I will fix the lint error later, thanks for the pr!

@Helloyunho Helloyunho merged commit 0247454 into harmonyland:main Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Helloyunho Helloyunho Helloyunho requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nyxoy44 @Helloyunho