Skip to content

Conversation

DjDeveloperr
Copy link
Member

i hope i didn't add any breaking change to this unintentionally, so please check on that in review
fix #141

Copy link
Contributor

@MierenManz MierenManz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some comments. Overall nice change and it mostly looks good to me.

Copy link
Member

@Helloyunho Helloyunho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall: less anys but much more unknowns

Copy link
Member

@Helloyunho Helloyunho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Helloyunho Helloyunho added the hacktoberfest-accepted Hacktoberfest 2021 label Oct 4, 2021
@Helloyunho Helloyunho merged commit 27921cb into main Oct 4, 2021
@DjDeveloperr DjDeveloperr deleted the any-experiment branch November 1, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted Hacktoberfest 2021

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Remove as many any types from code

3 participants