✨ feat: add slash commands decorators with type hinting #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DjDeveloperr
requested changes
Sep 30, 2021
DjDeveloperr
reviewed
Oct 1, 2021
DjDeveloperr
approved these changes
Oct 1, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This pr can be seen as a beginning to address the suggestion #229.
I noticed that type hinting as a whole can be improved, but I see you are already working on it, and I didn't want to mess with your style.
The
slash.tsexample has been updated to make it easier to test the changes.This pr doesn't really need to be merged, and you can just use it to find an implementation you like more.
Status