Skip to content

fix: add s3os object key #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Aug 3, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

迁移 s3 附件时,增加 object key

Which issue(s) this PR fixes:

Fixes #24

Special notes for your reviewer:

查看迁移到 s3 的附件是否具有 s3os.plugin.halo.run/object-key annotations 即可

Does this PR introduce a user-facing change?

迁移 s3 附件时增加 object key 字段

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Aug 3, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and JohnNiang August 3, 2023 09:36
Copy link

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Aug 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 4fecb75 into halo-sigs:main Aug 4, 2023
@LIlGG LIlGG deleted the fix/object-key branch February 27, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

迁移到 s3 的图片会抛出 Cannot obtain object key 异常
3 participants