Skip to content

Conversation

@JohnNiang
Copy link
Member

This PR refactors build scripts and workflows.

Meanwhile, some dependencies are bumped as well.

Refactor build scripts and workflows

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 18, 2025
@JohnNiang JohnNiang changed the title Refactor build scripts and workflows WIP: Refactor build scripts and workflows Jun 18, 2025
@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 18, 2025
@JohnNiang JohnNiang changed the title WIP: Refactor build scripts and workflows Refactor build scripts and workflows Jun 18, 2025
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 18, 2025
Icons({ compiler: "vue3" }),
HaloUIPluginBundlerKit({
outDir: {
dev: "../src/main/resources/console/",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里应该是要输出到 build 目录的 resources

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我记得开发环境下,是需要输出到源码目录才能正常更新。

@ruibaby
Copy link
Member

ruibaby commented Jun 18, 2025

如果一定要在这里将 UI 目录封装为 gradle 模块,我会在 halo-dev/halo#7568 中修改默认生产构建的目录为 build/dist。

@JohnNiang
Copy link
Member Author

如果一定要在这里将 UI 目录封装为 gradle 模块,我会在 halo-dev/halo#7568 中修改默认生产构建的目录为 build/dist。

Agree.

@ruibaby
Copy link
Member

ruibaby commented Jun 18, 2025

我建议等到 halo-dev/halo#7568 合并后发布新的包再合并此 PR,并且需要在 docs.halo.run 完善文档

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2025
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jun 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ruibaby ruibaby merged commit e31b994 into halo-dev:main Jun 19, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants