-
Notifications
You must be signed in to change notification settings - Fork 81
Refactor build scripts and workflows #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ui/vite.config.ts
Outdated
| Icons({ compiler: "vue3" }), | ||
| HaloUIPluginBundlerKit({ | ||
| outDir: { | ||
| dev: "../src/main/resources/console/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里应该是要输出到 build 目录的 resources
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我记得开发环境下,是需要输出到源码目录才能正常更新。
|
如果一定要在这里将 UI 目录封装为 gradle 模块,我会在 halo-dev/halo#7568 中修改默认生产构建的目录为 build/dist。 |
Agree. |
|
我建议等到 halo-dev/halo#7568 合并后发布新的包再合并此 PR,并且需要在 docs.halo.run 完善文档 |
Signed-off-by: Ryan Wang <[email protected]>
ruibaby
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR refactors build scripts and workflows.
Meanwhile, some dependencies are bumped as well.