Skip to content

Conversation

@ruibaby
Copy link
Member

@ruibaby ruibaby commented Dec 19, 2023

将 console 目录改为 ui。

Fixes #22

None

@f2c-ci-robot f2c-ci-robot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 19, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and guqing December 19, 2023 07:07
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 26, 2023
@guqing
Copy link
Member

guqing commented Dec 26, 2023

/hold 等待 halo 兼容 ui 目录

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 26, 2023
@ruibaby
Copy link
Member Author

ruibaby commented Dec 26, 2023

/hold 等待 halo 兼容 ui 目录

不用,现在输出目录还是 console,不会影响啥。并且 @halo-dev/ui-plugin-bundler-kit 是随着 Halo 发布的,所以后续只需要改这个包就行了。

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/unhold
/lgtm

@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 27, 2023
@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 27, 2023
@ruibaby
Copy link
Member Author

ruibaby commented Dec 27, 2023

Going to merge by normally.

@ruibaby ruibaby merged commit 1182e94 into halo-dev:main Dec 27, 2023
@ruibaby ruibaby deleted the chore/rename-console-folder branch December 27, 2023 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

将 console 源码目录重命名为 ui

3 participants