Skip to content

Conversation

@yangzidemuou
Copy link
Contributor

@yangzidemuou yangzidemuou commented Dec 13, 2023

解决windows下构建项目出现的编码错误问题 #19

None

解决windows下构建项目出现的编码错误问题
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and guqing December 13, 2023 09:47
@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Dec 13, 2023
build.gradle Outdated
}

tasks.withType(JavaCompile).configureEach {
options.encoding = "UTF-8"
Copy link
Member

@guqing guqing Dec 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

options.encoding = "UTF-8" 这行需要有缩进

可以参考 #19 (comment) 都 source、test和 doc 都配置一下

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 13, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yangzidemuou , thanks for your first contirbution!

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit eb3a128 into halo-dev:main Dec 14, 2023
@yangzidemuou yangzidemuou deleted the patch-1 branch December 14, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants