Skip to content

Conversation

@azertypow
Copy link

No description provided.

@halbgut
Copy link
Owner

halbgut commented Aug 8, 2020

Great idea with the back link! The global parameter also seems to make sense, although that breaks the back link functionality. If there are two references to the same footnote, you won't know which one to go back to. It also has the unpleasant side-effect of making the HTML invalid.

One alternative I see would be keeping track of how many references there are, giving each one a unique id. Then when generating the footnote, we'd probably want to generate multiple back links.

I think I'd rather opt for leaving out the g flag instead. I don't really see an elegant solution otherwise. What do you think?

Two more side-notes:

  1. I don't think this project needs a lock-file. The dependency to showdown should really be a peer dependency (didn't know about this feature back when I wrote this). So the project has no production dependencies. Thus the lock-file should be empty.
  2. This is super minor and we can keep it like this, but: now a days I'd avoid having developer specific lines in the .gitignore file. So having the .DS_Store is also not very nice. Instead I think developers should have their own global ignore files which contain all the things they would like to have ignored on their platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants