Background video still resets in 5.1.0 on fragment

[Sieboldianus]

I updated to revealjs 5.1.0 in hope the video reset problem would be gone (#2882), but this is not the case.

See the example slide here.

This is the code for the slide (partly markdown, with jekyll reveal-js):

<div style="position:absolute; margin-left: auto; margin-right: auto; top: 50px; left: 0; bottom: 0;" class="fragment">      
<p style="text-align:left;color:#00FEFF">
4 Facets:<br>
Location (Where?)<br>  
User origin (Who?)<br>
Tags (What?)<br>
Time (When?)
</p> 
</div>

<!-- .slide: data-background-video="https://wwwpub.zih.tu-dresden.de/~s7398234/slide_assets/2017_FlickrEuropeAni.webm" data-background-video-loop data-background-video-muted -->

That said.. thank you so much for RevealJS; overall it is a blessing to have!

[hakimel]

When I test this in the latest reveal.js version locally, background video isn't restarting when fragments are shown. This is the content I used to test:

<div class="slides">
  <section>Slide 1</section>
  <section data-background-video="https://wwwpub.zih.tu-dresden.de/~s7398234/slide_assets/2017_FlickrEuropeAni.webm" data-background-video-loop data-background-video-mute>
    Slide 2
    <div class="fragment">Fragment 1</div>
    <div class="fragment">Fragment 2</div>
  </section>
</div>

I do see the video restarting in your live demo. Not sure what the difference is.

[Sieboldianus]

Thank you for testing @hakimel , I will investigate this further and update here!

[Sieboldianus]

I need to debug this further, but I think it could be related to the note-plugin, see #3630 (comment) - [edit] Merging the fix did not solve the video restarting problem on my side..

[hakimel]

This issue has been fixed now. The root issue was that the reveal.js setState method (which the notes plugin uses) triggered videos to restart.

2ac0566#diff-954cee783f662520c2f8fe65c2e5ca400cb00858396f512ac7c5c61e69e28e74