Skip to content

Add API Key based auth #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 5, 2025
Merged

Add API Key based auth #770

merged 6 commits into from
Jul 5, 2025

Conversation

hahwul
Copy link
Owner

@hahwul hahwul commented Jul 5, 2025

Server Mode에서 API 키 기반 인증 기능을 추가합니다.

  • cmd/server.go: --api-key 플래그 추가 및 옵션 전달
  • pkg/model/options.go: APIKey, ServerType 필드 추가
  • pkg/server/server.go: API 키 인증 미들웨어 추가 (REST API 타입에만 적용)
  • docs/page/modes/server-mode.md: API 키 사용 방법 문서 업데이트

Server Mode에서 API 키 기반 인증 기능을 추가합니다.

- `cmd/server.go`: `--api-key` 플래그 추가 및 옵션 전달
- `pkg/model/options.go`: `APIKey`, `ServerType` 필드 추가
- `pkg/server/server.go`: API 키 인증 미들웨어 추가 (REST API 타입에만 적용)
- `docs/page/modes/server-mode.md`: API 키 사용 방법 문서 업데이트
@hahwul hahwul changed the title Add API Key based authen Add API Key based auth Jul 5, 2025
@hahwul hahwul added this to the v2.12.0 milestone Jul 5, 2025
@hahwul hahwul self-assigned this Jul 5, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @hahwul, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces API key-based authentication for the server mode, specifically targeting the REST API. This enhancement allows users to secure their Dalfox server instances by requiring a valid API key for incoming requests, improving the overall security posture of the server.

Highlights

  • API Key Command-Line Flag: A new --api-key flag has been added to the dalfox server command, allowing users to specify a secret key for authentication when starting the server.
  • Server Options Update: The core Options struct (pkg/model/options.go) now includes APIKey and ServerType fields to properly configure and pass authentication settings.
  • REST API Authentication Middleware: An API key authentication middleware has been implemented for the REST API server. When an API key is configured, all incoming requests to the REST API will be validated against this key, rejecting unauthorized access.
  • Comprehensive Documentation: The server mode documentation (docs/page/modes/server-mode.md) has been updated to include instructions on how to use the new --api-key flag and how to include the X-API-KEY header in curl requests.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces API key-based authentication. I've identified a potential timing attack vulnerability in the API key comparison that needs to be addressed. Additionally, I've suggested improvements for code style and maintainability.

hahwul and others added 2 commits July 5, 2025 22:56
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Copy link

codecov bot commented Jul 5, 2025

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/server/server.go 82.35% 2 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

hahwul and others added 3 commits July 5, 2025 22:58
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@hahwul hahwul merged commit e84bdcc into main Jul 5, 2025
6 checks passed
@hahwul hahwul deleted the feat/api-key-auth branch July 5, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant