- 
                Notifications
    
You must be signed in to change notification settings  - Fork 1.3k
 
Load args from env vars as long as var starts with H2OGPT_ #556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| python generate.py --base_model=h2oai/h2ogpt-oig-oasst1-512-6_9b | ||
| """ | ||
| fire.Fire(main) | ||
| H2O_Fire(main) | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChathurindaRanasinghe I only changed here, can you please review and also check other places where env vars are needed. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please review post merge.
| 
           Cool thanks!  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I was thinking of something related a month ago. I wanted to be able to set any parameter of main() via ENV. Thanks for this, since I think it takes care of that too.
What about just H2OGPT_x . Why need _PARAM? Also, ok to allow all lower-case too like we do in DAI? Thanks!
          
 ok, done in 4b90733 no prioritization for now (i.e. all caps taking precedence) can do if needed. also,  but with lower case   | 
    
          
 Ok, I think you mean 2nd case to be "true". ya, it's not toml, it's ok. Ya, and no need for prioritization like in DAI IMO. Thanks!  | 
    
          
 oops, that's right, sorry, updated.  | 
    
| 
           Can you add a note and example here? Thanks! We can keep all those older envs for now, don't want to break things if others using them. But good to know how to generally set the env for any main() parameters.  | 
    
          
  | 
    
c763063    to
    25fc298      
    Compare
  
    25fc298    to
    c5e040a      
    Compare
  
    
No description provided.