Properly clear terminal on Cursive::clear() #828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `buffer.write().clear()` over `printer.clear()` (which is
`self.buffer.write().fill(" ")`) helps with properly clear the cursive
screen area after invoking side TUI apps within it (i.e. vim)
Note, that this is not enough to clear the complete screen in case of
using ShadowView.
azat
added a commit
to azat/chdig
that referenced
this pull request
Jul 5, 2025
|
Hi, and thanks for the work! I'm just concerned that this would cause excessive I/O in most cases. Maybe we need a different function specifically for when another application may have messed up the screen. |
|
Hi @gyscos! I will be OK with a separate method, but AFAICS the |
|
This is an example for a problem - #831 (press |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
buffer.write().clear()overprinter.clear()(which isself.buffer.write().fill(" ")) helps with properly clear the cursive screen area after invoking side TUI apps within it (i.e. vim)Note, that this is not enough to clear the complete screen in case of using ShadowView.