Skip to content

Ungroup updates to go dependencies #2656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025
Merged

Ungroup updates to go dependencies #2656

merged 1 commit into from
Jun 9, 2025

Conversation

mihaimaruseac
Copy link
Collaborator

@mihaimaruseac mihaimaruseac commented May 21, 2025

Description of the PR

In #2613 I tried to group all dependencies in an attempt to reduce the number of times we need to rerun CI when it is flaky.

Unfortunately, this causes an issue since now the big PR that gets created for all the dependencies would just fail all CI jobs and have a large diff.

Meanwhile, with the split of CI intro multiple workflows, the flakiness decreased, so the problem is not that big, I think.

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If GraphQL schema is changed, GraphQL client updates/additions have been made
  • If OpenAPI spec is changed, make generate has been run
  • If ent schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

In #2613 I tried to group all dependencies in an attempt to reduce the number of times we need to rerun CI when it is flaky.

Unfortunately, this causes an issue since now the big PR that gets created for all the dependencies would just fail all CI jobs and have a large diff.

Meanwhile, with the split of CI intro multiple workflows, the flakiness decreased, so the problem is not that big, I think.

Signed-off-by: Mihai Maruseac <[email protected]>
@kodiakhq kodiakhq bot merged commit fbd2374 into main Jun 9, 2025
11 checks passed
@kodiakhq kodiakhq bot deleted the mihaimaruseac-patch-1 branch June 9, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants