merge upstream #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function call changed before introduced in example.
re-factored code for modular-todo-app
Response should be sent from callback.
Moved inconsistently placed comma in 03-internals.md
Update response send on model creation.
Updated code to match that found at Derick's repo: https://github.com/derickbailey/todomvc/tree/marionette/labs/architecture-examples/backbone_marionette
Here you are talking about the 'updateOnEnter' function that will be trigered by the key press event on the edit class, but the event was not on the events attribute, so I thought it should be added for clarity
Adding event into events attribute
Updated code to reflect Derick Bailey's repo
fixed links to base.css & bg.png
Rather than running 5 separate commands, this single line will install whichever ones are not currently installed.
The notation was different from the code in 02-fundametals.md. Fixes #525.
Added exclusion for log files to .gitignore.
Remove log file
reordered logs to match code sample
Use lower case first naming convention for objects
Merge Debian dependencies into one line in the README
re #537 larger font-size
Fix the printing of view's html content
…inside the root folder one has to go one level up to access site folder
corrected server static content directory
Update URL to Underscore docs
Typo fix
https links to twitter
Change the links for backbone and underscore in the boilerplate template to backbonejs.org and underscorejs.org respectively. Fixes #689
Update links in boilerplate template
Added missing 'validates' option to 'set' method
https links to twitter
Fix typo – from: togglecompleted, to: toggleCompleted
making ajaxSettings actually available in a scope
filter() example as method of Bacbone's Collection instead of Array
Change '!=' operator to '!==' in exercise 2
* Corrected improper punctuation of Latin abbreviation "i.e." * Correct improper punctuation of Latin abbreviation "e.g." * Fixed missing markup on two of the questions and removed an unnecessary "i.e." at the beginning of a sentence.
Update http://documentcloud.github.com/backbone/ to http://backbonejs.org. I also ran `grep documentcloud.github.com chapters/*.md` and came up with nothing else.
Statement should be "Overwriting jQuery ajax method - no actual request will be made" and not "Overwriting jQuery ajax method - now actual request will be made".
In certain cases, have to load actual jquery first
post releaseDate to Date format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
67 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.