fix: prevent segfault in helm.UnmarshalK8SYaml with empty YAML documents #1597
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a segfault that occurs when
helm.UnmarshalK8SYamlprocesses empty YAML documents (e.g.,---separators without content).Changes
EmptyDocumenttest case covering:---)---\n---\n---)Root Cause
The YAML decoder successfully decodes empty documents but returns
nilforrawYaml. The code then attempted to calljson.Marshal(rawYaml)on nil, causing a segfault.Test Plan