Skip to content

fix: issue --namespace showing twice #1452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 17, 2024
Merged

fix: issue --namespace showing twice #1452

merged 2 commits into from
Oct 17, 2024

Conversation

@james00012
Copy link
Contributor

@james00012 james00012 commented Sep 29, 2024

Description

Fixes #1446.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

@james00012 james00012 self-assigned this Sep 29, 2024
denis256
denis256 reviewed Sep 30, 2024
View reviewed changes
@james00012
Copy link
Contributor Author

james00012 commented Oct 15, 2024

Hi @denis256, PTAL.

@james00012 james00012 merged commit 754233f into master Oct 17, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@denis256 denis256 denis256 approved these changes

Assignees

@james00012 james00012

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[helm] The namespace is added twice to the helm command

3 participants

@james00012 @denis256