migrate to AWS SDKv2, updating only singnatures and making sure tests are passing #1451

wakeful · 2024-09-29T14:28:29Z

Description

This PR includes changes to upgrade the outdated AWS SDK to the newer SDKv2 version.

I focused on upgrading all calls from the legacy AWS SDKv1.
Updated function signatures to match the new SDKv2.
Fixed issues to ensure all tests are passing.

What's missing:
~~- Finalise porting modules/aws/auth.go (support for MFA and assume role). I complete this over the next few days.~~

Fixes #1432.

TODOs

Read the Gruntwork contribution guidelines.

Update the docs.
Run the relevant tests successfully, including pre-commit checks.
Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

migrated to AWS SDK v2.

james00012 · 2024-11-02T01:44:07Z

Hi @wakeful, thanks for making this contribution. It seems like some of the relevant tests are failing. Can you please run them and make sure they don't fail?

wakeful · 2024-11-02T16:25:02Z

hey @james03160927 I updated tests, rebase with latest master & bump all aws SDK v2 pkg - please try again if you get any errors 🙏 share the output log.

so0k · 2024-11-06T13:46:46Z

this is awesome @wakeful - but this should probably come with a major bump, for example for s3 fileupload I had to replace s3manager... and I can't remember other situations where the change in terratest bled through into my code (which could be more a problem with my code)...

Until this gets merged, I'm using your fork of terratest

replace github.com/gruntwork-io/terratest => github.com/wakeful/terratest v0.47.2-0.20241015095311-22a3870b391e

I'd like to see this merged (and I'd like to contribute some more utility functions such as testing Cloudfront Functions, Sfn State Machines, ...)

ref all the utilities I wrote here
https://github.com/envtio/base/tree/main/integ/aws

but I'm not sure if there's an interest for this by gruntworks (not sure if there's a slack or discord where this can be discussed?)

wakeful · 2024-11-06T13:56:30Z

thanks for testing @so0k!

I also have few more ideas / new helpers but first we need to merge this one.

but I'm not sure if there's an interest for this by gruntworks (not sure if there's a slack or discord where this can be discussed?)

recently there was a blog post about A stronger Terragrunt community with official Discord server - I'm hoping at some point other tools will also get a dedicated channel there.

james00012 · 2024-11-08T00:50:51Z

Seeing this error on packer unit test

    packer_basic_example_test.go:231: operation error EC2: ModifyImageAttribute, https response error StatusCode: 400, RequestID: 6679d41e-890b-42d7-a5ee-6a040ce75f2c, api error OperationNotPermitted: You can’t publicly share this image because block public access for AMIs is enabled for this account. To publicly share the image, you must call the DisableImageBlockPublicAccess API.

wakeful · 2024-11-08T08:42:37Z

hey @james03160927.

can’t publicly share this image because block public access for AMIs is enabled for this account

Based on the error above, it seems that in your AWS account (or AWS organisation) there is a policy blocking the sharing of the AMI with everyone. I’ve decided to modify the test to check if the AMI is private. This way, we won’t require any changes in your testing environment.

The fix has been pushed, and the branch has been rebased with the latest master.

james00012 · 2024-11-16T01:31:52Z

Can you rebase your change with the latest commit? It requires bigger circleCi resource to run the tests which I submitted here. #1472

wakeful · 2024-11-16T05:30:53Z

@james03160927 done 👍

james00012 · 2024-11-20T00:43:19Z

Still seeing failures in the following tests:
TestPackerDockerExampleLocal

TestPackerDockerExampleLocal 2024-11-18T23:49:01Z http_helper.go:58: Making an HTTP GET call to URL http://localhost:8080
TestPackerDockerExampleLocal 2024-11-18T23:49:01Z retry.go:103: HTTP GET to URL http://localhost:8080 returned an error: Get "http://localhost:8080": read tcp 127.0.0.1:39468->127.0.0.1:8080: read: connection reset by peer. Sleeping for 2s and will try again.
TestPackerDockerExampleLocal 2024-11-18T23:49:03Z retry.go:91: HTTP GET to URL http://localhost:8080
TestPackerDockerExampleLocal 2024-11-18T23:49:03Z http_helper.go:58: Making an HTTP GET call to URL http://localhost:8080
TestPackerDockerExampleLocal 2024-11-18T23:49:03Z retry.go:103: HTTP GET to URL http://localhost:8080 returned an error: Get "http://localhost:8080": dial tcp 127.0.0.1:8080: connect: connection refused. Sleeping for 2s and will try again.
TestPackerDockerExampleLocal 2024-11-18T23:49:05Z retry.go:91: HTTP GET to URL http://localhost:8080
TestPackerDockerExampleLocal 2024-11-18T23:49:05Z http_helper.go:58: Making an HTTP GET call to URL http://localhost:8080
TestPackerDockerExampleLocal 2024-11-18T23:49:05Z retry.go:103: HTTP GET to URL http://localhost:8080 returned an error: Get "http://localhost:8080": dial tcp 127.0.0.1:8080: connect: connection refused. Sleeping for 2s and will try again.
TestPackerDockerExampleLocal 2024-11-18T23:49:07Z retry.go:91: HTTP GET to URL http://localhost:8080
TestPackerDockerExampleLocal 2024-11-18T23:49:07Z http_helper.go:58: Making an HTTP GET call to URL http://localhost:8080
TestPackerDockerExampleLocal 2024-11-18T23:49:07Z retry.go:103: HTTP GET to URL http://localhost:8080 returned an error: Get "http://localhost:8080": dial tcp 127.0.0.1:8080: connect: connection refused. Sleeping for 2s and will try again.
TestPackerDockerExampleLocal 2024-11-18T23:49:09Z retry.go:91: HTTP GET to URL http://localhost:8080
TestPackerDockerExampleLocal 2024-11-18T23:49:09Z http_helper.go:58: Making an HTTP GET call to URL http://localhost:8080
TestPackerDockerExampleLocal 2024-11-18T23:49:09Z retry.go:103: HTTP GET to URL http://localhost:8080 returned an error: Get "http://localhost:8080": dial tcp 127.0.0.1:8080: connect: connection refused. Sleeping for 2s and will try again.
TestPackerDockerExampleLocal 2024-11-18T23:49:11Z retry.go:91: HTTP GET to URL http://localhost:8080
TestPackerDockerExampleLocal 2024-11-18T23:49:11Z http_helper.go:58: Making an HTTP GET call to URL http://localhost:8080
TestPackerDockerExampleLocal 2024-11-18T23:49:11Z retry.go:103: HTTP GET to URL http://localhost:8080 returned an error: Get "http://localhost:8080": dial tcp 127.0.0.1:8080: connect: connection refused. Sleeping for 2s and will try again.
TestPackerDockerExampleLocal 2024-11-18T23:49:13Z logger.go:67: Running command docker with args [compose --project-name testpackerdockerexamplelocal down]
TestPackerDockerExampleLocal 2024-11-18T23:49:13Z logger.go:67: Container testpackerdockerexamplelocal-web_app-1  Stopping
TestPackerDockerExampleLocal 2024-11-18T23:49:13Z logger.go:67: Container testpackerdockerexamplelocal-web_app-1  Stopping
TestPackerDockerExampleLocal 2024-11-18T23:49:13Z logger.go:67: Container testpackerdockerexamplelocal-web_app-1  Stopped
TestPackerDockerExampleLocal 2024-11-18T23:49:13Z logger.go:67: Container testpackerdockerexamplelocal-web_app-1  Removing
TestPackerDockerExampleLocal 2024-11-18T23:49:13Z logger.go:67: Container testpackerdockerexamplelocal-web_app-1  Removed
TestPackerDockerExampleLocal 2024-11-18T23:49:13Z logger.go:67: Network testpackerdockerexamplelocal_default  Removing
TestPackerDockerExampleLocal 2024-11-18T23:49:13Z logger.go:67: Network testpackerdockerexamplelocal_default  Removed
--- FAIL: TestPackerDockerExampleLocal (127.25s)

TestTerraformPackerExample

5s and will try again.
TestTerraformPackerExample 2024-11-18T23:58:59Z retry.go:91: HTTP GET to URL http://54.201.25.30:8080
TestTerraformPackerExample 2024-11-18T23:58:59Z http_helper.go:58: Making an HTTP GET call to URL http://54.201.25.30:8080
TestTerraformPackerExample 2024-11-18T23:58:59Z retry.go:103: HTTP GET to URL http://54.201.25.30:8080 returned an error: Get "http://54.201.25.30:8080": dial tcp 54.201.25.30:8080: connect: connection refused. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-18T23:59:04Z retry.go:91: HTTP GET to URL http://54.201.25.30:8080
TestTerraformPackerExample 2024-11-18T23:59:04Z http_helper.go:58: Making an HTTP GET call to URL http://54.201.25.30:8080
TestTerraformPackerExample 2024-11-18T23:59:04Z retry.go:103: HTTP GET to URL http://54.201.25.30:8080 returned an error: Get "http://54.201.25.30:8080": dial tcp 54.201.25.30:8080: connect: connection refused. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-18T23:59:09Z retry.go:91: HTTP GET to URL http://54.201.25.30:8080
TestTerraformPackerExample 2024-11-18T23:59:09Z http_helper.go:58: Making an HTTP GET call to URL http://54.201.25.30:8080
TestTerraformPackerExample 2024-11-18T23:59:09Z retry.go:103: HTTP GET to URL http://54.201.25.30:8080 returned an error: Get "http://54.201.25.30:8080": dial tcp 54.201.25.30:8080: connect: connection refused. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-18T23:59:14Z retry.go:91: HTTP GET to URL http://54.201.25.30:8080
TestTerraformPackerExample 2024-11-18T23:59:14Z http_helper.go:58: Making an HTTP GET call to URL http://54.201.25.30:8080
TestTerraformPackerExample 2024-11-18T23:59:14Z retry.go:103: HTTP GET to URL http://54.201.25.30:8080 returned an error: Get "http://54.201.25.30:8080": dial tcp 54.201.25.30:8080: connect: connection refused. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-18T23:59:19Z retry.go:91: HTTP GET to URL http://54.201.25.30:8080
TestTerraformPackerExample 2024-11-18T23:59:19Z http_helper.go:58: Making an HTTP GET call to URL http://54.201.25.30:8080
TestTerraformPackerExample 2024-11-18T23:59:20Z retry.go:103: HTTP GET to URL http://54.201.25.30:8080 returned an error: Get "http://54.201.25.30:8080": dial tcp 54.201.25.30:8080: connect: connection refused. Sleeping for 5s and will try again.

TestTerraformAwsRdsExample/mysql

=== NAME  TestTerraformAwsRdsExample/mysql
    apply.go:15: 
        	Error Trace:	/home/circleci/project/modules/terraform/apply.go:15
        	            				/home/circleci/project/test/terraform_aws_rds_example_test.go:108
        	Error:      	Received unexpected error:
        	            	FatalError{Underlying: error while running command: exit status 1; �[31m╷�[0m�[0m
        	            	�[31m│�[0m �[0m�[1m�[31mError: �[0m�[0m�[1mRequired plugins are not installed�[0m
        	            	�[31m│�[0m �[0m
        	            	�[31m│�[0m �[0m�[0mThe installed provider plugins are not consistent with the packages
        	            	�[31m│�[0m �[0mselected in the dependency lock file:
        	            	�[31m│�[0m �[0m  - registry.terraform.io/hashicorp/aws: the cached package for registry.terraform.io/hashicorp/aws 4.67.0 (in .terraform/providers) does not match any of the checksums recorded in the dependency lock file
        	            	�[31m│�[0m �[0m
        	            	�[31m│�[0m �[0mTerraform uses external plugins to integrate with a variety of different
        	            	�[31m│�[0m �[0minfrastructure services. To download the plugins required for this
        	            	�[31m│�[0m �[0mconfiguration, run:
        	            	�[31m│�[0m �[0m  terraform init
        	            	�[31m╵�[0m�[0m}
        	Test:       	TestTerraformAwsRdsExample/mysql

wakeful · 2024-11-20T07:13:47Z

I resolved the conflicts and will work on the failing tests later today.

wakeful · 2024-11-20T10:12:59Z

The issue in TestTerraformPackerExample and TestPackerDockerExampleLocal was related to a missing HTTP server. It seems that the Sinatra gem no longer installs an HTTP server by default, or it may require extra configuration. I added puma and configured Sinatra to use it. Both tests are now passing for me.

The TestTerraformAwsRdsExample/mysql issue seems more like a Terraform cache problem. I reran it locally, and it passed without any issues

wakeful · 2024-11-22T06:43:38Z

@james03160927 Can you rerun the tests again? After my investigation, they are not related to my changes. They also failed for me on the master branch, so I fixed them.

james00012 · 2024-11-25T02:44:27Z

HI @wakeful, would it be possible to create a separate PR for fixing the already failing tests? I still get the same error for TestTerraformAwsRdsExample/mysql test

wakeful · 2024-11-25T07:19:57Z

hey @james03160927

I still get the same error for TestTerraformAwsRdsExample/mysql test

This seems to be an issue with Terraform. I'll try to reproduce it. Could you share the Terraform version used in your CI? Unfortunately, the log output is not accessible to external contributors.

would it be possible to create a separate PR for fixing the already failing tests

Are you asking me to fix all tests on the master branch, or should I create another PR with the test changes pointing to wakeful:bump-aws-sdk-to-v2?

james00012

Overall LGTM. Just a few comments on the test changes.

james00012 · 2024-11-25T23:07:37Z

test/packer_basic_example_test.go


 	// website::tag::3::Check AMI's properties.
-	// Check if AMI is public
-	MakeAmiPublic(t, amiID, ec2Client)


Why are we deleting this line of code here and elsewhere? Does migrating to AWS SDK v2 require this change?

as mention in this comment #1451 (comment) To prevent this test from failing in your AWS account, I decided to remove the part that makes it public.

test/terraform_packer_example_test.go

james00012 · 2024-11-25T23:09:24Z

hey @james03160927

I still get the same error for TestTerraformAwsRdsExample/mysql test

This seems to be an issue with Terraform. I'll try to reproduce it. Could you share the Terraform version used in your CI? Unfortunately, the log output is not accessible to external contributors.

I think this is a transient error. Please ignore for now. We are using TERRAFORM_VERSION: 1.5.7 right now for CircleCi.

would it be possible to create a separate PR for fixing the already failing tests

Are you asking me to fix all tests on the master branch, or should I create another PR with the test changes pointing to wakeful:bump-aws-sdk-to-v2?

I was suggesting to make this solely focus on migrating to AWS SDK v2 changes. Your fix for HTTP server could be in a different PR.

wakeful · 2024-11-26T08:58:55Z

would it be possible to create a separate PR for fixing the already failing tests

Are you asking me to fix all tests on the master branch, or should I create another PR with the test changes pointing to wakeful:bump-aws-sdk-to-v2?

I was suggesting to make this solely focus on migrating to AWS SDK v2 changes. Your fix for HTTP server could be in a different PR.

@james03160927 Should I create a new PR with just the test fix? I added the HTTP fix here mainly because the tests were failing, and I wanted to ensure my branch was "green."

… are passing. gruntwork-io#1432

james00012 · 2024-12-02T14:12:49Z

I think it's all good now. Thanks for all the back and forth and addressing even the test failure issues. Let's merge the code now.

james00012

LGTM

wakeful requested a review from denis256 as a code owner September 29, 2024 14:28

wakeful force-pushed the bump-aws-sdk-to-v2 branch from 6646d68 to 83f34d2 Compare October 4, 2024 20:25

wakeful changed the title ~~[WIP] migrate to AWS SDKv2, updating only singnatures and making sure tests are passing~~ migrate to AWS SDKv2, updating only singnatures and making sure tests are passing Oct 4, 2024

wakeful mentioned this pull request Oct 6, 2024

Migration to aws-sdk-go-v2? #1432

Closed

wakeful force-pushed the bump-aws-sdk-to-v2 branch 2 times, most recently from 72d9de8 to 22a3870 Compare October 15, 2024 09:53

wakeful force-pushed the bump-aws-sdk-to-v2 branch from 22a3870 to e2ce5d3 Compare November 2, 2024 16:20

wakeful force-pushed the bump-aws-sdk-to-v2 branch from e2ce5d3 to cc1368f Compare November 8, 2024 08:36

wakeful mentioned this pull request Nov 12, 2024

Add SSO configuration support to Terratest #1460

Closed

wakeful force-pushed the bump-aws-sdk-to-v2 branch from cc1368f to 6e6ba19 Compare November 15, 2024 06:02

wakeful force-pushed the bump-aws-sdk-to-v2 branch from 6e6ba19 to 468b41b Compare November 16, 2024 05:29

wakeful force-pushed the bump-aws-sdk-to-v2 branch 2 times, most recently from 047b0ac to 826eccc Compare November 19, 2024 20:24

wakeful force-pushed the bump-aws-sdk-to-v2 branch from 826eccc to dbfbabd Compare November 20, 2024 07:12

wakeful force-pushed the bump-aws-sdk-to-v2 branch from dbfbabd to 63c1d7a Compare November 20, 2024 10:08

wakeful mentioned this pull request Nov 20, 2024

add platform parameter to docker run command. fix #1310 #1471

Merged

4 tasks

wakeful force-pushed the bump-aws-sdk-to-v2 branch from 63c1d7a to b1b65d8 Compare November 25, 2024 13:31

james00012 reviewed Nov 25, 2024

View reviewed changes

migrate to AWS SDKv2, updating only singnatures and making sure tests…

f5425c1

… are passing. gruntwork-io#1432

wakeful force-pushed the bump-aws-sdk-to-v2 branch from b1b65d8 to f5425c1 Compare November 26, 2024 09:01

wakeful requested a review from james00012 December 1, 2024 17:39

james00012 approved these changes Dec 2, 2024

View reviewed changes

james00012 merged commit ff9abea into gruntwork-io:master Dec 2, 2024
2 checks passed

Uh oh!

migrate to AWS SDKv2, updating only singnatures and making sure tests are passing #1451

migrate to AWS SDKv2, updating only singnatures and making sure tests are passing #1451

Uh oh!

Conversation

wakeful commented Sep 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

TODOs

Release Notes (draft)

Uh oh!

james00012 commented Nov 2, 2024

Uh oh!

wakeful commented Nov 2, 2024

Uh oh!

so0k commented Nov 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wakeful commented Nov 6, 2024

Uh oh!

james00012 commented Nov 8, 2024

Uh oh!

wakeful commented Nov 8, 2024

Uh oh!

james00012 commented Nov 16, 2024

Uh oh!

wakeful commented Nov 16, 2024

Uh oh!

james00012 commented Nov 20, 2024

Uh oh!

wakeful commented Nov 20, 2024

Uh oh!

wakeful commented Nov 20, 2024

Uh oh!

wakeful commented Nov 22, 2024

Uh oh!

james00012 commented Nov 25, 2024

Uh oh!

wakeful commented Nov 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

james00012 left a comment

Choose a reason for hiding this comment

Uh oh!

james00012 Nov 25, 2024

Choose a reason for hiding this comment

Uh oh!

wakeful Nov 26, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

james00012 commented Nov 25, 2024

Uh oh!

wakeful commented Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

james00012 commented Dec 2, 2024

Uh oh!

james00012 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

wakeful commented Sep 29, 2024 •

edited

Loading

so0k commented Nov 6, 2024 •

edited

Loading

wakeful commented Nov 25, 2024 •

edited

Loading

wakeful commented Nov 26, 2024 •

edited

Loading