Skip to content

Add NIOTS transport to E2E TLS-enabled tests #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Dec 9, 2024
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ let dependencies: [Package.Dependency] = [
),
.package(
url: "https://github.com/apple/swift-nio-ssl.git",
from: "2.27.2"
from: "2.29.0"
),
.package(
url: "https://github.com/apple/swift-nio-extras.git",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,61 +19,14 @@ import GRPCCore
import GRPCNIOTransportCore
import GRPCNIOTransportHTTP2TransportServices
import XCTest
import NIOSSL

final class HTTP2TransportNIOTransportServicesTests: XCTestCase {
private static let p12bundleURL = URL(fileURLWithPath: #filePath)
.deletingLastPathComponent() // (this file)
.deletingLastPathComponent() // GRPCHTTP2TransportTests
.deletingLastPathComponent() // Tests
.appendingPathComponent("Sources")
.appendingPathComponent("GRPCSampleData")
.appendingPathComponent("bundle")
.appendingPathExtension("p12")

@Sendable private static func loadIdentity() throws -> SecIdentity {
let data = try Data(contentsOf: Self.p12bundleURL)

var externalFormat = SecExternalFormat.formatUnknown
var externalItemType = SecExternalItemType.itemTypeUnknown
let passphrase = "password" as CFTypeRef
var exportKeyParams = SecItemImportExportKeyParameters()
exportKeyParams.passphrase = Unmanaged.passUnretained(passphrase)
var items: CFArray?

let status = SecItemImport(
data as CFData,
"bundle.p12" as CFString,
&externalFormat,
&externalItemType,
SecItemImportExportFlags(rawValue: 0),
&exportKeyParams,
nil,
&items
)

if status != errSecSuccess {
XCTFail(
"""
Unable to load identity from '\(Self.p12bundleURL)'. \
SecItemImport failed with status \(status)
"""
)
} else if items == nil {
XCTFail(
"""
Unable to load identity from '\(Self.p12bundleURL)'. \
SecItemImport failed.
"""
)
}

return ((items! as NSArray)[0] as! SecIdentity)
}

func testGetListeningAddress_IPv4() async throws {
let transport = GRPCNIOTransportCore.HTTP2ServerTransport.TransportServices(
address: .ipv4(host: "0.0.0.0", port: 0),
transportSecurity: .plaintext
transportSecurity: .plaintext,
config: .defaults
)

try await withThrowingDiscardingTaskGroup { group in
Expand Down Expand Up @@ -198,6 +151,33 @@ final class HTTP2TransportNIOTransportServicesTests: XCTestCase {
}
}

@Sendable private static func loadIdentity() throws -> SecIdentity {
let certificateKeyPairs = try SelfSignedCertificateKeyPairs()
let password = "somepassword"
let bundle = NIOSSLPKCS12Bundle(
certificateChain: [
try NIOSSLCertificate(bytes: certificateKeyPairs.server.certificate, format: .der)
],
privateKey: try NIOSSLPrivateKey(bytes: certificateKeyPairs.server.key, format: .der)
)
let pkcs12Bytes = try bundle.serialize(passphrase: password.utf8)
let options = [kSecImportExportPassphrase as String: password]
var rawItems: CFArray?
let status = SecPKCS12Import(
Data(pkcs12Bytes) as CFData,
options as CFDictionary,
&rawItems
)
guard status == errSecSuccess else {
XCTFail("Failed to import PKCS12 bundle: status \(status).")
throw HTTP2TransportNIOTransportServicesTestsError.failedToImportPKCS12
}
let items = rawItems! as! [[String: Any]]
let firstItem = items[0]
let identity = firstItem[kSecImportItemIdentity as String] as! SecIdentity
return identity
}

func testServerConfig_Defaults() throws {
let grpcTLSConfig = HTTP2ServerTransport.TransportServices.TLS.defaults(
identityProvider: Self.loadIdentity
Expand Down Expand Up @@ -229,4 +209,8 @@ final class HTTP2TransportNIOTransportServicesTests: XCTestCase {
XCTAssertEqual(grpcTLSConfig.trustRoots, .systemDefault)
}
}

enum HTTP2TransportNIOTransportServicesTestsError: Error {
case failedToImportPKCS12
}
#endif
Loading
Loading