Move name resolution retry from managed channel to name resolver (take #2) #9812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change has these main aspects to it:
1. Removal of any name resolution responsibility from ManagedChannelImpl
2. Creation of a new RetryScheduler to own generic retry logic
- Can also be used outside the name resolution context
3. Creation of a new RetryingNameScheduler that can be used to wrap any
polling name resolver to add retry capability
4. A new facility in NameResolver to allow implementations to notify
listeners on the success of name resolution attempts
- RetryingNameScheduler relies on this
- Do not change the public API - Use a hacky internal callback - More unit test coverage
Contributor
Author
|
cc: @larry-safran |
ejona86
reviewed
Jan 12, 2023
Member
ejona86
left a comment
ejona86
left a comment
There was a problem hiding this comment.
There's two problems not addressed:
- We need a utility for third-party polling NameResolvers to use
- We need to give time for migration. This could be handled by using RetryingNameResolver in ManagedChannelImpl
If we want to implement this over multiple PRs, then ManagedChannelImpl could be the only user of RetryingNameResolver for now and we add the API in a later PR.
core/src/main/java/io/grpc/internal/BackoffPolicyRetryScheduler.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/grpc/internal/BackoffPolicyRetryScheduler.java
Outdated
Show resolved
Hide resolved
ejona86
reviewed
Feb 2, 2023
temawi
commented
Feb 4, 2023
Contributor
Author
temawi
left a comment
temawi
left a comment
There was a problem hiding this comment.
I made some changes based on a few assumptions. PTAL and let me know if it doesn't look right.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change has these main aspects to it: